Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Assembly Version #201

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Update Assembly Version #201

merged 1 commit into from
Mar 27, 2020

Conversation

BHoMBot
Copy link
Member

@BHoMBot BHoMBot commented Mar 27, 2020

Closes #200

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Mar 27, 2020
FraserGreenroyd
FraserGreenroyd approved these changes Mar 27, 2020
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am happy this resolves the issue of updating the AssemblyFileVersion to 3.2.0.0.

I will leave for repo owners to review and merge when they're happy.

@peterjamesnugent peterjamesnugent added this to the BHoM 3.2 β MVP milestone Mar 27, 2020
@peterjamesnugent
Copy link
Member

/azp run MidasCivil_Toolkit.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@peterjamesnugent
Copy link
Member

/azp run MidasCivil_Toolkit.CheckCompliance

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@peterjamesnugent
Copy link
Member

/azp run MidasCivil_Toolkit.CheckCompliance

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@peterjamesnugent
Copy link
Member

@FraserGreenroyd CheckInstaller is failing for some reason?

@peterjamesnugent
Copy link
Member

/azp run MidasCivil_Toolkit.CheckCompliance

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@peterjamesnugent
Copy link
Member

/azp run MidasCivil_Toolkit.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FraserGreenroyd
Copy link
Contributor

@peterjamesnugent yeah slight problem that @IsakNaslundBh and I have resolved, should work now. Sorry!

@peterjamesnugent
Copy link
Member

Cheers @FraserGreenroyd all is forgiven 😄

peterjamesnugent
peterjamesnugent approved these changes Mar 27, 2020
View reviewed changes
Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@peterjamesnugent peterjamesnugent merged commit f4f2b07 into master Mar 27, 2020
@peterjamesnugent peterjamesnugent deleted the MidasCivil_Toolkit-#200-UpdateAssemblyVersion branch March 27, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterjamesnugent peterjamesnugent peterjamesnugent approved these changes

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

Assignees
No one assigned
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
BHoM 3.2 β MVP
Development

Successfully merging this pull request may close these issues.

Update AssemblyFileVersion
3 participants
@BHoMBot @peterjamesnugent @FraserGreenroyd