-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull back bar results #419
base: develop
Are you sure you want to change the base?
Conversation
Moved and cleaned up old solution, not tested
Added new private helper
added new private helper
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to approve, works well and allows the user to pull results for bars as well as beams.
Can you just address the formatting please - you should be able to highlight the whole document and do it in one go.
Tuple<List<int>, List<int>> sortedIds = | ||
new Tuple<List<int>, List<int>>(barIds, beamIds); | ||
return sortedIds; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you format this correctly please.
@@ -0,0 +1,103 @@ | |||
/* | |||
* This file is part of the Buildings and Habitats object Model (BHoM) | |||
* Copyright (c) 2015 - 2024, the respective contributors. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will also need to be made 2025.
@BHoMBot check compliance |
@peterjamesnugent to confirm, the following actions are now queued:
|
NOTE: Depends on
Issues addressed by this PR
Closes #414
Added new support to pull back results from axial elements
Test files
https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/Lusas_Toolkit/%23419-PullBackBarResults?csf=1&web=1&e=tONSjz
Changelog
Additional comments
Additional comments