Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull back bar results #419

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

EmmaSander
Copy link
Contributor

@EmmaSander EmmaSander commented Nov 13, 2024

NOTE: Depends on

Issues addressed by this PR

Closes #414

Added new support to pull back results from axial elements

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/Lusas_Toolkit/%23419-PullBackBarResults?csf=1&web=1&e=tONSjz

Changelog

  • New method to sort the element ids into categories.
  • Separate methods for pulling back results for beams and for bars
  • Cleans up previous pull requests/branches

Additional comments

Additional comments

Moved and cleaned up old solution, not tested
Added new private helper
added new private helper
@peterjamesnugent peterjamesnugent added the type:feature New capability or enhancement label Jan 8, 2025
Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve, works well and allows the user to pull results for bars as well as beams.

Can you just address the formatting please - you should be able to highlight the whole document and do it in one go.

Comment on lines 95 to 97
Tuple<List<int>, List<int>> sortedIds =
new Tuple<List<int>, List<int>>(barIds, beamIds);
return sortedIds;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you format this correctly please.

@@ -0,0 +1,103 @@
/*
* This file is part of the Buildings and Habitats object Model (BHoM)
* Copyright (c) 2015 - 2024, the respective contributors. All rights reserved.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will also need to be made 2025.

@peterjamesnugent
Copy link
Member

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jan 8, 2025

@peterjamesnugent to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New support needed to pull back Bar results from Lusas 21
2 participants