Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update postbuild events and project references #261

Merged
merged 3 commits into from
Jun 4, 2020
Merged

Update postbuild events and project references #261

merged 3 commits into from
Jun 4, 2020

Conversation

peterjamesnugent
Copy link
Member

NOTE: Depends on

BHoM/admin#5

Issues addressed by this PR

Test files

Changelog

@peterjamesnugent peterjamesnugent added severity:critical No workaround exists. Essential to continue size:XS Measured in seconds type:external-api-changes Imposed changes, including from dependency across other BHoM repos labels Jun 4, 2020
@peterjamesnugent peterjamesnugent added this to the BHoM 3.2 β MVP milestone Jun 4, 2020
@peterjamesnugent peterjamesnugent self-assigned this Jun 4, 2020
FraserGreenroyd
FraserGreenroyd requested changes Jun 4, 2020
View reviewed changes
Lusas_Adapter/Lusas_Adapter.csproj Outdated Show resolved Hide resolved
Lusas_Engine/Lusas_Engine.csproj Outdated Show resolved Hide resolved
Lusas_oM/Lusas_oM.csproj Outdated Show resolved Hide resolved
FraserGreenroyd
FraserGreenroyd approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on workshop review, testing installer plus toolkits for building and running sample scripts

@peterjamesnugent peterjamesnugent merged commit 1e5c5d5 into master Jun 4, 2020
@peterjamesnugent peterjamesnugent deleted the BHoM_Admin-#5-Referencing branch June 4, 2020 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@IsakNaslundBh IsakNaslundBh Awaiting requested review from IsakNaslundBh

Assignees

@peterjamesnugent peterjamesnugent

Labels
severity:critical No workaround exists. Essential to continue size:XS Measured in seconds type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
Milestone
BHoM 3.2 β MVP
Development

Successfully merging this pull request may close these issues.
2 participants
@peterjamesnugent @FraserGreenroyd