Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thermal Resistance Conversion Methods #113

Merged

Conversation

vgreen-BH
Copy link
Contributor

Issues addressed by this PR

Closes #111

Adds new conversion methods to convert R-value and U-value between metric and imperial.

Test files

https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/03_Alpha/BHoM/BHoM_Engine/Facade_Engine/BHoM%20PR%20Test%20Files/240423_LocalisationToolkit_Thermal%20Resistance%20Test.gh?csf=1&web=1&e=xjr10t

Additional comments

Required for Facade Embodied Carbon Toolkit

@vgreen-BH vgreen-BH added the type:feature New capability or enhancement label Apr 23, 2024
@vgreen-BH vgreen-BH added this to the BHoM 7.2 β MVP milestone Apr 23, 2024
@vgreen-BH vgreen-BH requested a review from enarhi April 23, 2024 22:59
@vgreen-BH vgreen-BH self-assigned this Apr 23, 2024
@enarhi
Copy link
Member

enarhi commented Apr 23, 2024

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Apr 23, 2024

@enarhi to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 3 requests in the queue ahead of you.

Copy link
Member

@enarhi enarhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, used test file and cross checked against conversion factor both ways and it is applied correctly.

@enarhi
Copy link
Member

enarhi commented Apr 24, 2024

@BHoMBot check required

Copy link

bhombot-ci bot commented Apr 24, 2024

@enarhi to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

Copy link

bhombot-ci bot commented Apr 24, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Apr 24, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented May 7, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 7f9d8b0 into develop May 7, 2024
12 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Localisation_Toolkit-#111-ThermalResistance branch May 7, 2024 12:56
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Thermal Resistance Conversion
3 participants