Make oM properties virtual #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FraserGreenroyd
approved these changes
Apr 7, 2020
There was a problem hiding this comment.
This appears to be correct in accordance with the issue being resolved by @BHoMBot.
I will leave it to the Toolkit lead to also review and merge as appropriate.
I would recommend the Toolkit lead to do a usual thorough review in case the virtual keyword has been added inadvertently to the wrong properties.
|
/azp run LifeCycleAssessment_Toolkit.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
FraserGreenroyd
deleted the
LifeCycleAssessment_Toolkit-#61-MakePropertiesVirtual
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #61