Fix GetElementScope method to work with multiple fragments

[michaelhoehn]

NOTE: Depends on

Issues addressed by this PR

Closes #266

Test files

Test File

Changelog

Additional comments

[michaelhoehn]

@BHoMBot check required

[bhombot-ci]

@michaelhoehn to confirm, the following checks are now queued:

• code-compliance
• documentation-compliance
• project-compliance
• core
• null-handling
• serialisation
• versioning
• installer

[michaelhoehn]

@BHoMBot check installer

[bhombot-ci]

@michaelhoehn to confirm, the following checks are now queued:

• installer

[michaelhoehn]

@BHoMBot check project-compliance

[bhombot-ci]

@michaelhoehn to confirm, the following checks are now queued:

• project-compliance

[michaelhoehn]

@BHoMBot check compliance

[bhombot-ci]

@michaelhoehn to confirm, the following checks are now queued:

• code-compliance
• documentation-compliance
• project-compliance
• branch-compliance
• dataset-compliance
• copyright-compliance

[bhombot-ci]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[FraserGreenroyd]

On a pure code review, I have requested changes to what is written in the file due to some redundant measures.

However, it is difficult to test/review this PR against the issue which was originally raised. The original issue is inadequate in providing replicable details for the bug, the steps necessary to reproduce and test independently, or even describing what should be expected vs should not be expected. As such, it will make it difficult to merge this PR when it is difficult to work out what the original problem was from one single screenshot that is inadequately described.

[michaelhoehn]

On a pure code review, I have requested changes to what is written in the file due to some redundant measures.

However, it is difficult to test/review this PR against the issue which was originally raised. The original issue is inadequate in providing replicable details for the bug, the steps necessary to reproduce and test independently, or even describing what should be expected vs should not be expected. As such, it will make it difficult to merge this PR when it is difficult to work out what the original problem was from one single screenshot that is inadequately described.

@FraserGreenroyd I tried to address your valid concerns regarding the issue description as well as adjust the code. Please feel free to re-review when you're able.

#266 (comment)

[FraserGreenroyd]

From a code review this looks fine based on the conversations with @michaelhoehn

[michaelhoehn]

Thanks for the code review @FraserGreenroyd. I'm happy to merge this one I receive a functionality review from @kayleighhoude @enarhi or @shivanierambaran if possible. 🦖

[enarhi]

LGTM

[michaelhoehn]

@BHoMBot check compliance

[bhombot-ci]

@michaelhoehn to confirm, the following checks are now queued:

• code-compliance
• documentation-compliance
• project-compliance
• branch-compliance
• dataset-compliance
• copyright-compliance

[michaelhoehn]

@BHoMBot check required

[bhombot-ci]

@michaelhoehn to confirm, the following checks are now queued:

• code-compliance
• documentation-compliance
• project-compliance
• core
• null-handling
• serialisation
• versioning
• installer

[bhombot-ci]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[michaelhoehn]

@BHoMBot check installer
@BHoMBot check versioning

[bhombot-ci]

@michaelhoehn to confirm, the following checks are now queued:

• installer
• versioning

There are 9 requests in the queue ahead of you.

[michaelhoehn]

@BHoMBot check versioning

[bhombot-ci]

@michaelhoehn to confirm, the following checks are now queued:

• versioning

Dismissing as comments have been addressed.

[michaelhoehn]

@BHoMBot check ready-to-merge

[bhombot-ci]

@michaelhoehn to confirm, the following checks are now queued:

• ready-to-merge

There are 72 requests in the queue ahead of you.