-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
6.1 Deployment #91
6.1 Deployment #91
Conversation
@BHoMBot check beta-merge-status |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 49 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Followed testing procedure as per instructions on Ladybug Toolkit Test Procedure word document. 3.1.1 and 4.1.1 tests passed. 4.1.1 test initially failed when path is pasted on file explorer but passed when it was ran directly from the ProgramData folder. 230315 beta tested against Ladybug Toolkit.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
230316 beta tested against Ladybug Toolkit Testing Procedure and passed with no errors. 4.1.1 still need to be run directly from the ProgramData folder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test procedure failed due to upstream issue when installing from scratch. Relies on BHoM/Python_Toolkit#100 in order to work properly - so need to wait for that in order to give a full review. (after implementation in Python_Toolkit, this works fine)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested using BHoM_6.1.230315.beta.0 and the Environment's LadyBugTools_Toolkit testing procedure using the testing procedure document 0001_LadyBugTools_Toolkit.
After setting the toggle to true, epw was successfully converted to csv. All “Test” components return a successful result (“True”). Passed.
After launching the run_tests.bat file, all 127 tests passed. However, has to be launched directly from the C:\ProgramData\BHoM\Extensions\PythonCode\LadybugTools_Toolkit folder. Passed.
Overall, passes.
@BHoMBot check beta-merge-status |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 50 requests in the queue ahead of you. |
MERGE REPORT - 2023-03-19 15:13. DETAILS: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested against BHoM_6.1.230320.beta.0 and toolkit test procedure. All parts of test procedure returned a pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am satisfied with the level of testing conducted on this pull request for it to be deployed to the 6.1 beta.
@bhombot-ci[bot] just to let you know, I have provided a |
@bhombot-ci[bot] just to let you know, I have provided a |
@bhombot-ci[bot] just to let you know, I have provided a |
2 similar comments
@bhombot-ci[bot] just to let you know, I have provided a |
@bhombot-ci[bot] just to let you know, I have provided a |
@BHoMBot check compliance |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 124 requests in the queue ahead of you. |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 303 requests in the queue ahead of you. |
@BHoMBot check serialisation |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 387 requests in the queue ahead of you. |
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
There are 461 requests in the queue ahead of you. |
Changes were made, subsequent reviews taking priority.
@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: dataset-compliance, ready-to-merge |
@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results. |
LadybugTools_Toolkit
Feature
Compliance
Documentation
External-api-changes