Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 5.1 Previous Version Attributes #52

Merged
merged 1 commit into from
Apr 7, 2022
Merged

Remove 5.1 Previous Version Attributes #52

merged 1 commit into from
Apr 7, 2022

Conversation

BHoMBot
Copy link
Member

@BHoMBot BHoMBot commented Apr 2, 2022

Remove 5.1 Previous Version Attributes

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Apr 2, 2022
FraserGreenroyd
FraserGreenroyd approved these changes Apr 2, 2022
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from a DevOps perspective after code review.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 7, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • core

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 7, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 7, 2022

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 7, 2022

@BHoMBot just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on LifeCycleAssessment_Toolkit

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 7, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • copyright-compliance

There are 43 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 45c0322 into main Apr 7, 2022
@FraserGreenroyd FraserGreenroyd deleted the RemovePreviousVersionAttributes51 branch April 7, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

Assignees
No one assigned
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BHoMBot @FraserGreenroyd