Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated .json #50

Merged
merged 2 commits into from
Mar 18, 2022
Merged

Updated .json #50

merged 2 commits into from
Mar 18, 2022

Conversation

jamesramsden-bh
Copy link
Contributor

Issues addressed by this PR

Closes #49
Updated Json file added to allow users to run LB TK env installer by linking to and copying from this file.

Test files

Changelog

Additional comments

@jamesramsden-bh jamesramsden-bh added the type:bug Error or unexpected behaviour label Mar 18, 2022
@jamesramsden-bh jamesramsden-bh self-assigned this Mar 18, 2022
@jamesramsden-bh
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 18, 2022

@jamesramsden-bh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

@jamesramsden-bh
Copy link
Contributor Author

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 18, 2022

@jamesramsden-bh to confirm, the following checks are now queued:

  • copyright-compliance

@jamesramsden-bh
Copy link
Contributor Author

@BHoMBot check required
@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 18, 2022

@jamesramsden-bh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer
  • copyright-compliance

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have reviewed the code, warning messages make sense and are appropriate.
Have reviewed the accompanying wiki page, made slight wording changes in discussion with @jamesramsden-bh .
Both LGTM.

@FraserGreenroyd FraserGreenroyd merged commit ca0d24c into main Mar 18, 2022
@FraserGreenroyd FraserGreenroyd deleted the LadybugTools_Toolkit-#49-UpdateJson branch March 18, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Json for beta release
2 participants