Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Honeybee+ Surface to Environment objects (Panels/Openings) #5

Merged
merged 5 commits into from
May 21, 2020

Conversation

FraserGreenroyd
Copy link
Contributor

Issues addressed by this PR

Fixes #4

Test files

Available here

Changelog

Additional comments

@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label May 18, 2020
@FraserGreenroyd FraserGreenroyd self-assigned this May 18, 2020
@FraserGreenroyd
Copy link
Contributor Author

/azp run LadybugTools_Toolkit.CheckCompliance

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FraserGreenroyd
Copy link
Contributor Author

/azp run LadybugTools_Toolkit.CheckCompliance

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tg359
Copy link
Contributor

tg359 commented May 18, 2020

Just jumping in here. Are we focusing on HB-Legacy solely, or including HB+ objects? There is quite a big difference between the workflows and data stored in them. I prefer the HB+ stuff as it's a bit more neat, but most workflows currently use the HB-Legacy objects. The HB+ components would more easily convert to/from BHoM directly.

image

@FraserGreenroyd
Copy link
Contributor Author

@tg359 currently doing HB+ objects in this PR. Long term I think it would be good to do both.

I was speaking with Antoine this morning about this further and the LB team are developing up workflows to take LB models into JSON and a C# schema (which we're using as a nuget in this PR ready) to read that JSON and convert to C# objects which will make some of the workflows easier (as you can see from the code, this is basically taking an IronPython dynamic object and converting it to the BHoM object.

I'm not sure how well this PR would work with the legacy surface, but might be good to try out.

Long term it would be good to plan out the full workflows for this toolkit (in addition to getting something up for installer use and discussion), I'll probably suggest a workshop as we get to the end of the milestone to plan out tasks with @MarthaVoul @michaelhoehn @charliebrookerBH etc. 😄

@FraserGreenroyd FraserGreenroyd changed the title Convert Honeybee Surface to Environment objects (Panels/Openings) Convert Honeybee+ Surface to Environment objects (Panels/Openings) May 18, 2020
Copy link

@MajaLindroth MajaLindroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran test script and it worked for me

@FraserGreenroyd
Copy link
Contributor Author

/azp run LadybugTools_Toolkit.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FraserGreenroyd FraserGreenroyd merged commit ff45faf into master May 21, 2020
@FraserGreenroyd FraserGreenroyd deleted the LadybugTools_Toolkit-#4-HBSrfToBHoM branch May 21, 2020 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert Honeybee surfaces to Environment Panels
3 participants