-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert Honeybee+ Surface to Environment objects (Panels/Openings) #5
Conversation
/azp run LadybugTools_Toolkit.CheckCompliance |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run LadybugTools_Toolkit.CheckCompliance |
Azure Pipelines successfully started running 1 pipeline(s). |
Just jumping in here. Are we focusing on HB-Legacy solely, or including HB+ objects? There is quite a big difference between the workflows and data stored in them. I prefer the HB+ stuff as it's a bit more neat, but most workflows currently use the HB-Legacy objects. The HB+ components would more easily convert to/from BHoM directly. |
@tg359 currently doing HB+ objects in this PR. Long term I think it would be good to do both. I was speaking with Antoine this morning about this further and the LB team are developing up workflows to take LB models into JSON and a C# schema (which we're using as a nuget in this PR ready) to read that JSON and convert to C# objects which will make some of the workflows easier (as you can see from the code, this is basically taking an I'm not sure how well this PR would work with the legacy surface, but might be good to try out. Long term it would be good to plan out the full workflows for this toolkit (in addition to getting something up for installer use and discussion), I'll probably suggest a workshop as we get to the end of the milestone to plan out tasks with @MarthaVoul @michaelhoehn @charliebrookerBH etc. 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ran test script and it worked for me
/azp run LadybugTools_Toolkit.CheckInstaller |
Azure Pipelines successfully started running 1 pipeline(s). |
Issues addressed by this PR
Fixes #4
Test files
Available here
Changelog
Additional comments