Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate openfield methods and update versions #42

Merged
merged 101 commits into from
Jun 9, 2022

Conversation

tg359
Copy link
Contributor

@tg359 tg359 commented Mar 2, 2022

Issues addressed by this PR

Closes #38
Closes #40

Migrated a load of methods for calculating external comfort (both abstract and spatial) for different spatial typologies into this toolkit to be closer to the base LB methods they use a lot. Should also make this far easier to implement on other machines too as it removes dependency from external tools (other than the necessary Radiance and EnergyPlus).

Test files

Here's the test file for this. It requires that the LadybugTools PythonEnvironment is installed before it runs (though should tell the user that before anything runs anyway). It also requires that Ladybug Tools is installed, as well as Radiance and Honeybee. You can get the installer here - https://www.food4rhino.com/en/app/ladybug-tools, and there are instructions here - https://github.com/ladybug-tools/lbt-grasshopper/wiki/1.1-Windows-Installation-Steps. It might also be worth running the Ladybug.Versioner component that comes with this to give you the most up-to-date version on youtr machine as I'm not sure if this is included with the installer.
38.zip

Changelog

Additional comments

@tg359 tg359 added severity:medium Slows progress, but workaround is possible size:L Measured in days status:WIP PR in progress and still in draft, not ready for formal review priority:high High impact, high user value, driven by live project needs labels Mar 2, 2022
@tg359 tg359 self-assigned this Mar 2, 2022
@tg359 tg359 requested review from akaraiskou and lydiamfd7 April 12, 2022 18:49
@tg359 tg359 removed the status:WIP PR in progress and still in draft, not ready for formal review label Apr 12, 2022
@tg359
Copy link
Contributor Author

tg359 commented Apr 12, 2022

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 12, 2022

@tg359 to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

@tg359
Copy link
Contributor Author

tg359 commented Apr 14, 2022

@BHoMBot check code-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 14, 2022

@tg359 to confirm, the following checks are now queued:

  • code-compliance

@tg359
Copy link
Contributor Author

tg359 commented Apr 21, 2022

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 21, 2022

@tg359 to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 14 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Apr 21, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@tg359
Copy link
Contributor Author

tg359 commented May 9, 2022

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented May 9, 2022

@tg359 to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

@tg359 tg359 requested a review from charliebrookerBH June 8, 2022 10:07
Copy link
Contributor

@charliebrookerBH charliebrookerBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my machine - all functionality works as expected (and it's absolutely awesome).

@tg359
Copy link
Contributor Author

tg359 commented Jun 8, 2022

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 8, 2022

@tg359 to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

@tg359
Copy link
Contributor Author

tg359 commented Jun 8, 2022

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 8, 2022

@tg359 to confirm, the following checks are now queued:

  • copyright-compliance

@tg359 tg359 force-pushed the LadybugTools_Toolkit-#38-MigrateOpenfieldMethods branch from 5b84f0c to 0cafade Compare June 8, 2022 14:05
@tg359
Copy link
Contributor Author

tg359 commented Jun 8, 2022

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 8, 2022

@tg359 to confirm, the following checks are now queued:

  • copyright-compliance

@tg359
Copy link
Contributor Author

tg359 commented Jun 8, 2022

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 8, 2022

@tg359 to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 1 requests in the queue ahead of you.

@BingWangUS
Copy link

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 8, 2022

@BingWangUS to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

@BingWangUS
Copy link

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 8, 2022

@BingWangUS to confirm, the following checks are now queued:

  • copyright-compliance

There are 9 requests in the queue ahead of you.

@tg359 tg359 force-pushed the LadybugTools_Toolkit-#38-MigrateOpenfieldMethods branch from e5218fa to b2ad787 Compare June 9, 2022 08:51
Copy link
Contributor

@charliebrookerBH charliebrookerBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving reverting changes

@tg359 tg359 merged commit 5580cf6 into main Jun 9, 2022
@tg359 tg359 deleted the LadybugTools_Toolkit-#38-MigrateOpenfieldMethods branch June 9, 2022 09:01
@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:high High impact, high user value, driven by live project needs severity:medium Slows progress, but workaround is possible size:L Measured in days type:feature New capability or enhancement
Projects
None yet
5 participants