-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate openfield methods and update versions #42
Migrate openfield methods and update versions #42
Conversation
@BHoMBot check required |
@tg359 to confirm, the following checks are now queued:
|
@BHoMBot check code-compliance |
@tg359 to confirm, the following checks are now queued:
|
@BHoMBot check required |
@tg359 to confirm, the following checks are now queued:
There are 14 requests in the queue ahead of you. |
The check |
@BHoMBot check required |
@tg359 to confirm, the following checks are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on my machine - all functionality works as expected (and it's absolutely awesome).
@BHoMBot check required |
@tg359 to confirm, the following checks are now queued:
|
@BHoMBot check copyright-compliance |
@tg359 to confirm, the following checks are now queued:
|
…ing sim reloading methods
5b84f0c
to
0cafade
Compare
@BHoMBot check copyright-compliance |
@tg359 to confirm, the following checks are now queued:
|
@BHoMBot check required |
@tg359 to confirm, the following checks are now queued:
There are 1 requests in the queue ahead of you. |
@BHoMBot check required |
@BingWangUS to confirm, the following checks are now queued:
|
@BHoMBot check copyright-compliance |
@BingWangUS to confirm, the following checks are now queued:
There are 9 requests in the queue ahead of you. |
e5218fa
to
b2ad787
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving reverting changes
Issues addressed by this PR
Closes #38
Closes #40
Migrated a load of methods for calculating external comfort (both abstract and spatial) for different spatial typologies into this toolkit to be closer to the base LB methods they use a lot. Should also make this far easier to implement on other machines too as it removes dependency from external tools (other than the necessary Radiance and EnergyPlus).
Test files
Here's the test file for this. It requires that the LadybugTools PythonEnvironment is installed before it runs (though should tell the user that before anything runs anyway). It also requires that Ladybug Tools is installed, as well as Radiance and Honeybee. You can get the installer here - https://www.food4rhino.com/en/app/ladybug-tools, and there are instructions here - https://github.com/ladybug-tools/lbt-grasshopper/wiki/1.1-Windows-Installation-Steps. It might also be worth running the Ladybug.Versioner component that comes with this to give you the most up-to-date version on youtr machine as I'm not sure if this is included with the installer.
38.zip
Changelog
Additional comments