Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start of milestone changes for 8.0 #251

Merged
merged 2 commits into from
Sep 23, 2024
Merged

Start of milestone changes for 8.0 #251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a645bb
Update assembly file version to 8.0.0.0 and AssemblyVersion to 8.0.0.0
BHoMBot Sep 20, 2024
2d064ef
Remove previous version attributes for 8.0
BHoMBot Sep 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions LadybugTools_Adapter/LadybugTools_Adapter.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,13 @@

<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<AssemblyVersion>7.0.0.0</AssemblyVersion>
<AssemblyVersion>8.0.0.0</AssemblyVersion>

Check failure on line 5 in LadybugTools_Adapter/LadybugTools_Adapter.csproj

View check run for this annotation

BHoMBot-CI / project-compliance

LadybugTools_Adapter/LadybugTools_Adapter.csproj#L5 

Assembly Version should be set to 7.0.0.0
<Description>https://github.com/BHoM/LadybugTools_Toolkit</Description>
<Version>6.0.0</Version>
<Authors>BHoM</Authors>
<Copyright>Copyright © https://github.com/BHoM</Copyright>
<RootNamespace>BH.Adapter.LadybugTools</RootNamespace>
<FileVersion>7.3.0.0</FileVersion>
<FileVersion>8.0.0.0</FileVersion>

Check failure on line 11 in LadybugTools_Adapter/LadybugTools_Adapter.csproj

View check run for this annotation

BHoMBot-CI / project-compliance

LadybugTools_Adapter/LadybugTools_Adapter.csproj#L11 

Assembly File Version should be set to 7.3.0.0
<OutputPath>..\Build\</OutputPath>
</PropertyGroup>

Expand Down Expand Up @@ -88,7 +88,7 @@
</ItemGroup>

<Target Name="PostBuild" AfterTargets="PostBuildEvent">
<Exec Command="xcopy &quot;$(TargetDir)$(TargetFileName)&quot; &quot;C:\ProgramData\BHoM\Assemblies&quot; /C /Y" />

Check warning on line 91 in LadybugTools_Adapter/LadybugTools_Adapter.csproj

View check run for this annotation

BHoMBot-CI / project-compliance

LadybugTools_Adapter/LadybugTools_Adapter.csproj#L91 

Post Build event should be correctly set to copy the compiled DLL to the BHoM Assemblies folder
</Target>

</Project>
2 changes: 0 additions & 2 deletions LadybugTools_Engine/Convert/HexCode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ public static partial class Convert
[Description("Converts a colour to its respective RGB hexadecimal code (eg. white => #ffffff).")]
[Input("colour", "The colour to convert into a hex code.")]
[Output("hex", "The corresponding hex code.")]
[PreviousVersion("7.3", "BH.Engine.LadyBugTools.Convert.ToHexCode(System.Drawing.Color)")]
public static string ToHexCode(this Color colour)
{
return $"#{colour.R.ToString("X2")}{colour.G.ToString("X2")}{colour.B.ToString("X2")}";
Expand All @@ -48,7 +47,6 @@ public static string ToHexCode(this Color colour)
[Description("Converts a string that is in the RGB hexadecimal format into a colour. (eg. #ffffff => white).")]
[Input("hex", "The hexadecimal representation of a colour.")]
[Output("colour", "The corresponding colour.")]
[PreviousVersion("7.3", "BH.Engine.LadyBugTools.Convert.FromHexCode(System.String)")]
public static Color? FromHexCode(this string hex)
{
if (hex.IsNullOrEmpty())
Expand Down
4 changes: 2 additions & 2 deletions LadybugTools_Engine/LadybugTools_Engine.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<AssemblyVersion>7.0.0.0</AssemblyVersion>
<AssemblyVersion>8.0.0.0</AssemblyVersion>

Check failure on line 4 in LadybugTools_Engine/LadybugTools_Engine.csproj

View check run for this annotation

BHoMBot-CI / project-compliance

LadybugTools_Engine/LadybugTools_Engine.csproj#L4 

Assembly Version should be set to 7.0.0.0
<Description>https://github.com/BHoM/LadybugTools_Toolkit</Description>
<Version>6.0.0</Version>
<Authors>BHoM</Authors>
<Copyright>Copyright © https://github.com/BHoM</Copyright>
<RootNamespace>BH.Engine.LadyBugTools</RootNamespace>
<FileVersion>7.3.0.0</FileVersion>
<FileVersion>8.0.0.0</FileVersion>

Check failure on line 10 in LadybugTools_Engine/LadybugTools_Engine.csproj

View check run for this annotation

BHoMBot-CI / project-compliance

LadybugTools_Engine/LadybugTools_Engine.csproj#L10 

Assembly File Version should be set to 7.3.0.0
<OutputPath>..\Build\</OutputPath>
</PropertyGroup>
<ItemGroup>
Expand Down
4 changes: 2 additions & 2 deletions LadybugTools_oM/LadybugTools_oM.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<AssemblyVersion>7.0.0.0</AssemblyVersion>
<AssemblyVersion>8.0.0.0</AssemblyVersion>

Check failure on line 4 in LadybugTools_oM/LadybugTools_oM.csproj

View check run for this annotation

BHoMBot-CI / project-compliance

LadybugTools_oM/LadybugTools_oM.csproj#L4 

Assembly Version should be set to 7.0.0.0
<Description>https://github.com/BHoM/LadybugTools_Toolkit</Description>
<Version>6.0.0</Version>
<Authors>BHoM</Authors>
<Copyright>Copyright © https://github.com/BHoM</Copyright>
<RootNamespace>BH.oM.LadybugTools</RootNamespace>
<FileVersion>7.3.0.0</FileVersion>
<FileVersion>8.0.0.0</FileVersion>

Check failure on line 10 in LadybugTools_oM/LadybugTools_oM.csproj

View check run for this annotation

BHoMBot-CI / project-compliance

LadybugTools_oM/LadybugTools_oM.csproj#L10 

Assembly File Version should be set to 7.3.0.0
<OutputPath>..\Build\</OutputPath>
</PropertyGroup>
<ItemGroup>
Expand Down