Move engine methods utilising serialisation to Adapter Execute

[Tom-Kingstone]

NOTE: Depends on

Issues addressed by this PR

Closes #143

The engine methods: GetMaterial, GetTypology, SimulationResult, and ExternalComfort have been converted to adapter methods callable by Execute commands, that now utilise the LadybugToolsAdapter serialisation methods.

Test files

LBT_Tests.zip
Ensure the EPW file path is valid, then set toggles to True in order (GetMaterial, GetTypology, SimulationResult, ExternalComfort) and wait for them to finish computing, check for any warnings or errors, and finally check that the returning objects contain data in each property - This is testing whether the serialiser is pulling and pushing correctly.

Additional comments

You must have pollination version 1.35.14 installed for these components to work - the methods check for this.

[Tom-Kingstone]

@BHoMBot check compliance
@BHoMBot check core

[bhombot-ci]

@Tom-Kingstone to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance
• check core

[Tom-Kingstone]

@BHoMBot check core

[bhombot-ci]

@Tom-Kingstone to confirm, the following actions are now queued:

• check core

[Tom-Kingstone]

@BHoMBot check compliance

[bhombot-ci]

@Tom-Kingstone to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance

[Tom-Kingstone]

@BHoMBot check compliance
@BHoMBot check required

[bhombot-ci]

@Tom-Kingstone to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance
• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

[bhombot-ci]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[FraserGreenroyd]

As discussed on a call, Engine shouldn't use Adapter - @Tom-Kingstone will take a look at using Execute options instead and update the PR accordingly tomorrow/later int he week 😄

[bhombot-ci]

@Tom-Kingstone to confirm, the following actions are now queued:

• check copyright-compliance

[bhombot-ci]

@Tom-Kingstone fix requested for copyright headers.

The errors with the copyright headers on the CS (.cs) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

Each CS (.cs) file that does not have the current copyright header will have it applied. The current copyright header can be examined here.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix copyright headers ref. 19180266457

[Tom-Kingstone]

@BHoMBot fix copyright headers ref. 19180266457

[bhombot-ci]

@Tom-Kingstone I have queued up your request to fix copyright headers. There are 0 requests in the queue ahead of you.

[bhombot-ci]

@Tom-Kingstone I am now going to fix the copyright compliance in accordance with the annotations previously made.

[bhombot-ci]

@Tom-Kingstone to confirm I have now resolved the copyright compliance and pushed a commit to this Pull Request.

[Tom-Kingstone]

@BHoMBot check compliance
@BHoMBot check core

[bhombot-ci]

@Tom-Kingstone to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance
• check core

[Tom-Kingstone]

@BHoMBot check versioning

[bhombot-ci]

@Tom-Kingstone to confirm, the following actions are now queued:

• check versioning

[FraserGreenroyd]

I think the adapter references, of which only Adapter_oM is needed, should have gone into the oM project, not the engine project?

[Tom-Kingstone]

@BHoMBot check compliance
@BHoMBot check core

[bhombot-ci]

@Tom-Kingstone to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance
• check core

[Tom-Kingstone]

@BHoMBot check compliance
@BHoMBot check required

[bhombot-ci]

@Tom-Kingstone to confirm, the following actions are now queued:

• check code-compliance
• check documentation-compliance
• check project-compliance
• check branch-compliance
• check dataset-compliance
• check copyright-compliance
• check code-compliance
• check documentation-compliance
• check project-compliance
• check core
• check null-handling
• check serialisation
• check versioning
• check installer

[bhombot-ci]

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[bhombot-ci]

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

[FraserGreenroyd]

It's not great with the global variable but as discussed offline, not a lot we can do right now, so we'll merge this as a working solution for alpha testing and we can have more chats on improvements @Tom-Kingstone

[Tom-Kingstone]

@BHoMBot check installer
@BHoMBot check unit-tests
@BHoMBot check ready-to-merge

[bhombot-ci]

@Tom-Kingstone to confirm, the following actions are now queued:

• check installer
• check unit-tests
• check ready-to-merge

[Tom-Kingstone]

@BHoMBot check ready-to-merge

[bhombot-ci]

@Tom-Kingstone to confirm, the following actions are now queued:

• check ready-to-merge