Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.3 Deployment #116

Merged
merged 17 commits into from
Sep 21, 2023
Merged

6.3 Deployment #116

merged 17 commits into from
Sep 21, 2023

Conversation

tg359
tg359 previously requested changes Sep 13, 2023
Copy link
Contributor

@tg359 tg359 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested using BuroHappold_BHoM_6.3.230913.beta.0.msi using LadybugTools_Toolkit_TestScript.gh (last updated June 14 2023, including some versioning updates to components), and Pollination 1.28.3 and there were some failures. 👎

image

… to avoid failure in passing data between languages
@tg359 tg359 requested a review from Tom-Kingstone September 18, 2023 08:59
Copy link
Contributor

@Tom-Kingstone Tom-Kingstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with BHoM_6.3.230918.beta.0.msi artefact.
Going through the testing procedure, everything passes, however there are two warnings on the ExternalComfort panel:

f5066b33-d3fe-45e8-95d0-999094833bd7

There are also 3 warnings when running run_tests.bat:

07911cff-016a-46f4-acc3-3945ae99dc46
However, after checking these with @tg359, these warnings can be safely ignored as they are non-breaking.
All round this passes all tests 👍

@albinber
Copy link

@BHoMBot check compliance

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 19, 2023

@albinber to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 204 requests in the queue ahead of you.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 20, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @peterjamesnugent on ETABS_Toolkit

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 20, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 20, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation

There are 135 requests in the queue ahead of you.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 20, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Versioning_Toolkit

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Checked by DevOps following Testing Sprint. Everything is satisfactory, DevOps clear to merge.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: ready-to-merge

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Sep 21, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd dismissed tg359’s stale review September 21, 2023 09:58

Tom approved following new tests and updates

@FraserGreenroyd FraserGreenroyd merged commit 6be7b0b into main Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants