Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update referencing and post build #136

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Update referencing and post build #136

merged 1 commit into from
Jun 4, 2020

Conversation

MajaLindroth
Copy link
Contributor

NOTE: Depends on

BHoM/admin#5

Issues addressed by this PR

Closes #

Test files

Changelog

Additional comments

@MajaLindroth MajaLindroth added the type:external-api-changes Imposed changes, including from dependency across other BHoM repos label Jun 4, 2020
@MajaLindroth MajaLindroth self-assigned this Jun 4, 2020
FraserGreenroyd
FraserGreenroyd approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on workshop review, testing installer plus toolkits for building and running sample scripts

@FraserGreenroyd FraserGreenroyd merged commit d8178c5 into master Jun 4, 2020
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Admin-#5-Referencing branch June 4, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@tg359 tg359 Awaiting requested review from tg359

Assignees

@MajaLindroth MajaLindroth

Labels
type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MajaLindroth @FraserGreenroyd