Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pull BarPrestressLoad functionality #300

Merged
merged 1 commit into from
May 12, 2023

Conversation

johannaisak
Copy link
Contributor

@johannaisak johannaisak commented May 5, 2023

Functionality to pull lack of fit and initial strain will be added separately.

Could be tidied up to get the associated bars in a separate method to reuse on other pull load methods.

NOTE: Depends on

Issues addressed by this PR

Closes #97

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/GSA_Toolkit/%23300-Read-BarPrestressLoad?csf=1&web=1&e=weygNH

Changelog

Additional comments

Functionality to pull lack of fit and initial strain will be added separately.

Could be tidied up to get the associated bars in a separate method to reuse on other pull load methods.
@johannaisak johannaisak added the type:feature New capability or enhancement label May 5, 2023
@johannaisak johannaisak added this to the BHoM 6.2 β MVP milestone May 5, 2023
@johannaisak johannaisak self-assigned this May 5, 2023
@johannaisak johannaisak linked an issue May 5, 2023 that may be closed by this pull request
Copy link
Contributor

@TosteSkDa TosteSkDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected for both GSA8.7 and 10.1. Code looks good.

@johannaisak
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented May 10, 2023

@johannaisak to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 48 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented May 10, 2023

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@johannaisak
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2023

@johannaisak to confirm, the following actions are now queued:

  • check core
  • check project-compliance

There are 12 requests in the queue ahead of you.

@IsakNaslundBh
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented May 12, 2023

@IsakNaslundBh to confirm, the following actions are now queued:

  • check ready-to-merge

@IsakNaslundBh IsakNaslundBh merged commit 273e23c into develop May 12, 2023
@IsakNaslundBh IsakNaslundBh deleted the GSA_Toolkit-#97-Read-BarPrestressLoad branch May 12, 2023 10:55
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GSA_Toolkit: Read BarPrestressLoad
3 participants