Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added output to CustomCommant #299

Merged

Conversation

johannaisak
Copy link
Contributor

@johannaisak johannaisak commented May 2, 2023

Enables using CustomCommant to read data from GSA

NOTE: Depends on

Issues addressed by this PR

Closes #298

Added output to CustomCommant. Please check new functionality and also the general execute commands from the 6.1 milestone test file

Test files

https://burohappold.sharepoint.com/:f:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/GSA_Toolkit/%23299-CustomCommand-doesnt-give-output?csf=1&web=1&e=VYeUzI

Changelog

Additional comments

Enables using CustomCommant to read data from GSA
@johannaisak johannaisak added the type:bug Error or unexpected behaviour label May 2, 2023
@johannaisak johannaisak added this to the BHoM 6.2 β MVP milestone May 2, 2023
@johannaisak johannaisak self-assigned this May 2, 2023
@johannaisak johannaisak linked an issue May 2, 2023 that may be closed by this pull request
Copy link
Contributor

@TosteSkDa TosteSkDa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both general commands and custom commands. All works very well. Code looks good. Also tried to play around with other GWA commands and those worked perfectly as well with expected results.

@johannaisak
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented May 3, 2023

@johannaisak to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented May 3, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented May 3, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@johannaisak
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented May 3, 2023

@johannaisak to confirm, the following actions are now queued:

  • check ready-to-merge

@IsakNaslundBh IsakNaslundBh merged commit 16808b5 into develop May 4, 2023
@IsakNaslundBh IsakNaslundBh deleted the GSA_Toolkit-#298-CustomCommand-doesnt-give-output branch May 4, 2023 06:00
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GSA_Toolkit: CustomCommand doesn't give output
3 participants