Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue pushing gravity loads with meshes with more than one face #259

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Jun 15, 2022

NOTE: Depends on

Issues addressed by this PR

Closes #258

Special case for getting ids from FEMesh

Get Ids from FEFaces instead of host FEMesh when producing IDList.

Adding in OrderBy to ensure IDString is as simple as possible

Test files

https://burohappold.sharepoint.com/:f:/s/BHoM/Esm46kmSSANDghV6Hu9HtH0BxJZNmiT3_IK1NWnd849prw?e=UiKicn

Changelog

Additional comments

Get Ids from FEFaces instead of host FEMesh when producing IDList.

Adding in OrderBy to ensure IDString is as simple as possible
@IsakNaslundBh IsakNaslundBh added the type:bug Error or unexpected behaviour label Jun 15, 2022
@IsakNaslundBh IsakNaslundBh requested a review from alelom June 15, 2022 14:58
@IsakNaslundBh IsakNaslundBh self-assigned this Jun 15, 2022
GSA_Adapter/Convert/ToGsa/Group.cs Outdated Show resolved Hide resolved
@alelom alelom self-requested a review June 15, 2022 15:09
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 15, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance

Copy link
Member

@alelom alelom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on:

  • code: LGTM after comments
  • test file: objects and loads appear correctly pushed

@alelom
Copy link
Member

alelom commented Jun 15, 2022

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 15, 2022

@alelom to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 15, 2022

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 15, 2022

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Contributor

@JosefTaylor JosefTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds OK, but cannot test as I don't have GSA installed.
I suggested a change as a public method name is misspelled, but I don't mind if you don't.

GSA_Adapter/Convert/ToGsa/Group.cs Show resolved Hide resolved
@alelom
Copy link
Member

alelom commented Jun 15, 2022

@BHoMBot ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 15, 2022

@alelom sorry, I didn't understand.
Was that comment an instruction for me? If so, could you state again what check you would like me to do?
For a list of available instructions, please see this wiki page.

@alelom
Copy link
Member

alelom commented Jun 15, 2022

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 15, 2022

@alelom to confirm, the following checks are now queued:

  • ready-to-merge

There are 46 requests in the queue ahead of you.

@IsakNaslundBh
Copy link
Contributor Author

/azp run GSA_Toolkit.CheckCore

@IsakNaslundBh IsakNaslundBh merged commit bb830ab into main Jun 16, 2022
@IsakNaslundBh IsakNaslundBh deleted the GSA_Toolkit-#258-AddSUpportFOrMultiFaceMeshesWhenPushingGravityLoads branch June 16, 2022 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gravity loads on Meshes with multiple faces fail to push
3 participants