-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue pushing gravity loads with meshes with more than one face #259
Fix issue pushing gravity loads with meshes with more than one face #259
Conversation
Get Ids from FEFaces instead of host FEMesh when producing IDList. Adding in OrderBy to ensure IDString is as simple as possible
@BHoMBot check compliance |
@IsakNaslundBh to confirm, the following checks are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved based on:
- code: LGTM after comments
- test file: objects and loads appear correctly pushed
@BHoMBot check required |
@alelom to confirm, the following checks are now queued:
|
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds OK, but cannot test as I don't have GSA installed.
I suggested a change as a public method name is misspelled, but I don't mind if you don't.
@BHoMBot ready-to-merge |
@alelom sorry, I didn't understand. |
@BHoMBot check ready-to-merge |
@alelom to confirm, the following checks are now queued:
There are 46 requests in the queue ahead of you. |
/azp run GSA_Toolkit.CheckCore |
NOTE: Depends on
Issues addressed by this PR
Closes #258
Special case for getting ids from FEMesh
Get Ids from FEFaces instead of host FEMesh when producing IDList.
Adding in OrderBy to ensure IDString is as simple as possible
Test files
https://burohappold.sharepoint.com/:f:/s/BHoM/Esm46kmSSANDghV6Hu9HtH0BxJZNmiT3_IK1NWnd849prw?e=UiKicn
Changelog
Additional comments