Create AnalysisStage Class and Convert Method #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BHoMBot check compliance |
IsakNaslundBh
requested changes
Feb 9, 2021
| string id = ""; | ||
|
|
||
| // String type | ||
| if (int.TryParse(elements[i].ToString(), out int idInt)) |
There was a problem hiding this comment.
This syntax (putting it as 'out int idInt' does not compile with all the versions of c# we support. You will need to define the int on a row above
Suggested change
| if (int.TryParse(elements[i].ToString(), out int idInt)) | |
| int idInt; | |
| if (int.TryParse(elements[i].ToString(), out idInt)) |
IsakNaslundBh
requested changes
Feb 10, 2021
There was a problem hiding this comment.
Generally works really well, nice functionality with being able to control with properties as well as elements and or ids!
Just a comment on the index control, as we have added a Number property to the stage, we need to be able to explicitly set it. See some suggestions below:
|
|
||
| objectIds += " " + id; | ||
| } | ||
|
|
There was a problem hiding this comment.
Some small tweaks here so the number property makes its way into GSA:
- Would make the index be the number of the object, something like:
index = stage.Number.ToString(); - After this is done, need to update the GSAId fragment on the stage, to make sure it matches the number. Something like this should help with that:
stage.SetAdapterId(typeof(BH.oM.Adapters.GSA.GSAId), stage.Number);
For this 2nd step to work, you will need to add a using:using BH.Engine.Adapter;
IsakNaslundBh
approved these changes
Feb 12, 2021
|
@BHoMBot check installer |
|
@IsakNaslundBh to confirm, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
Issues addressed by this PR
Closes #222
Test files
Test file #222
Changelog
Additional comments
Creates an AnalysisStage class in the GSA_oM and adds a corresponding convert method to the GSA Adapter. Supports the following type inputs: double, int, string, ISectionProperty, LinkConstraint, ISurfaceProperty and elements supported in the GSA Adapter. Note that all inputs must either be or have a GSA Id.