Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update namespace of oM and Engine #179

Merged
merged 2 commits into from
Jun 3, 2020
Merged

Update namespace of oM and Engine #179

merged 2 commits into from
Jun 3, 2020

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented May 29, 2020 •
edited
Loading

NOTE: Depends on

Issues addressed by this PR

Closes #178

Update namespace of oM and Engine

Test files

https://burohappold.sharepoint.com/:f:/s/BHoM/EnM9pRCIaNFElgPdT_4we-sBI4GL4fhRszxUIIp_0BzvMA?e=tIiNNX

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:compliance Non-conforming to code guidelines label May 29, 2020
@IsakNaslundBh IsakNaslundBh added this to the BHoM 3.2 β MVP milestone May 29, 2020
@IsakNaslundBh IsakNaslundBh requested review from alelom and al-fisher May 29, 2020 09:54
@IsakNaslundBh IsakNaslundBh self-assigned this May 29, 2020
@IsakNaslundBh
Copy link
Contributor Author

/azp run GSA_Toolkit.CheckCompliance

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@IsakNaslundBh IsakNaslundBh requested a review from johannaisak June 3, 2020 16:07
johannaisak
johannaisak approved these changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@johannaisak johannaisak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@IsakNaslundBh IsakNaslundBh merged commit f7d276a into master Jun 3, 2020
@IsakNaslundBh IsakNaslundBh deleted the GSA_Toolkit-178-UpdateNamespaceOfOmAndEngine branch June 3, 2020 16:21
@alelom alelom mentioned this pull request Jun 3, 2020
Closed
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johannaisak johannaisak johannaisak approved these changes

@alelom alelom Awaiting requested review from alelom

@al-fisher al-fisher Awaiting requested review from al-fisher

Assignees

@IsakNaslundBh IsakNaslundBh

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
BHoM 3.2 β MVP
Development

Successfully merging this pull request may close these issues.

GSA_Toolkit: Update namespace of oM and Engine
2 participants
@IsakNaslundBh @johannaisak