Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File_Adapter: verify if file's attributes exist before attempting to use them to decide whether to read it or not #169

Merged
merged 2 commits into from
Jul 19, 2023

Conversation

alelom
Copy link
Member

@alelom alelom commented Jul 18, 2023

Issues addressed by this PR

Closes #168

Test files

See #168

Changelog

Additional comments

...before attempting to use them to decide whether to read it or not
@alelom alelom requested a review from pawelbaran July 18, 2023 14:51
@alelom alelom self-assigned this Jul 18, 2023
@alelom alelom added the type:bug Error or unexpected behaviour label Jul 18, 2023
Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code reviewed and tested - happy to approve! 👍

@pawelbaran
Copy link
Member

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 19, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 17 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check unit-tests
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 19, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check unit-tests
  • check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 19, 2023

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 19, 2023

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jul 19, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 18 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit 324d02f into develop Jul 19, 2023
@FraserGreenroyd FraserGreenroyd deleted the File_Adapter-#168-fileAttributesRead branch July 19, 2023 11:11
@bhombot-ci bhombot-ci bot mentioned this pull request Sep 11, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
3 participants