Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Mongo version 2.18 #145

Merged
merged 12 commits into from
Nov 24, 2022
Merged

Upgrade to Mongo version 2.18 #145

merged 12 commits into from
Nov 24, 2022

Conversation

adecler
Copy link
Member

@adecler adecler commented Nov 17, 2022 •
edited
Loading

Issues addressed by this PR

Closes BHoM/BHoM_Engine#2948

Test files

Additional comments

This one is slightly more complex: I replaced the code that was duplicating the BH.Engine.Serialiser.Convert.FromJson with a direct call to it. This repo seems to have a ton of unnecessary dependencies but I leave that for a separate task as it will require more testing. I just removed unused packages that were causing warnings at compile time.

@adecler adecler added the type:external-api-changes Imposed changes, including from dependency across other BHoM repos label Nov 17, 2022
@adecler adecler self-assigned this Nov 17, 2022
@adecler
Copy link
Member Author

adecler commented Nov 18, 2022

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 18, 2022

@adecler to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 16 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 22, 2022

@adecler just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

FraserGreenroyd
FraserGreenroyd previously approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See this review

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 22, 2022

@adecler just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 22, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation

There are 9 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 22, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 23 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 22, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check serialisation

There are 18 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 22, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check serialisation

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 22, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check serialisation

There are 11 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 22, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check serialisation

There are 3 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 22, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check serialisation

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 22, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check serialisation

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 22, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check serialisation

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check serialisation

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check serialisation

There are 2 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2022

@adecler just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on CSharp_Toolkit

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

There are 13 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

There are 14 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core

There are 8 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 39 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

The check project-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is documentation-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 9677744908

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 9677744908

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is documentation-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 9677744908

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

@FraserGreenroyd I have now provided a passing check on reference 9677744908 as requested.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 9677742818

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

@FraserGreenroyd I have now provided a passing check on reference 9677742818 as requested.

FraserGreenroyd
FraserGreenroyd approved these changes Nov 24, 2022
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been tested against the test scripts for the end of milestone and everything is still working happily.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 2 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd merged commit a89d1a2 into main Nov 24, 2022
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Engine-#2948-UpgradeMongo branch November 24, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alelom alelom alelom left review comments

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

Assignees

@adecler adecler

Labels
type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make sure the same version of MongoDB is used across all repos
3 participants
@adecler @FraserGreenroyd @alelom