Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write to file continues if BeautifyJson fails #110

Merged
merged 1 commit into from
Jan 28, 2021
Merged

Write to file continues if BeautifyJson fails #110

merged 1 commit into from
Jan 28, 2021

Conversation

alelom
Copy link
Member

@alelom alelom commented Jan 28, 2021

Issues addressed by this PR

Closes #109

Test files

Changelog

Additional comments

@alelom alelom self-assigned this Jan 28, 2021
@alelom alelom added the type:feature New capability or enhancement label Jan 28, 2021
@alelom alelom changed the title Add try-catch around BeautifyJson Add try-catch around BeautifyJson to help with Excel push Jan 28, 2021
@alelom alelom changed the title Add try-catch around BeautifyJson to help with Excel push If BeautifyJson fails, write to file must continue Jan 28, 2021
@alelom alelom changed the title If BeautifyJson fails, write to file must continue Write to file continues if BeautifyJson fails Jan 28, 2021
FraserGreenroyd
FraserGreenroyd approved these changes Jan 28, 2021
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 28, 2021

@FraserGreenroyd to confirm, check-installer task is now queued.

@FraserGreenroyd
Copy link
Contributor

/azp run File_Toolkit.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@FraserGreenroyd FraserGreenroyd merged commit aff52e3 into master Jan 28, 2021
@FraserGreenroyd FraserGreenroyd deleted the File_Adapter-#108-ExceptionInBeautify branch January 28, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

Assignees

@alelom alelom

Labels
type:feature New capability or enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

If BeautifyJson fails, write to file must continue
2 participants
@alelom @FraserGreenroyd