Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File_Adapter: Create partial class placed in File_Adapter to be moved to File_Engine #134

Closed
alelom opened this issue May 24, 2022 · 0 comments · Fixed by #135
Closed

File_Adapter: Create partial class placed in File_Adapter to be moved to File_Engine #134

alelom opened this issue May 24, 2022 · 0 comments · Fixed by #135
Assignees
@alelom
Labels
type:bug Error or unexpected behaviour type:compliance Non-conforming to code guidelines

Comments

@alelom
Copy link
Member

alelom commented May 24, 2022

Broken rules:

The Create partial class in:
https://github.com/BHoM/File_Toolkit/blob/main/File_Adapter/Methods/CreateFSDirectory.cs
should not exist in the File_Adapter project.

This causes conflicts when referencing both File_Adapter and File_Engine in another project:
image

Suggestions to restore compliance:

Move the file to the File_Engine.
@alelom alelom added type:bug Error or unexpected behaviour type:compliance Non-conforming to code guidelines labels May 24, 2022
@alelom alelom self-assigned this May 24, 2022
@alelom alelom changed the title File_Adapter: Create partial class placed also in File_Adapter causes conflicts when referencing both File_Adapter and File_Engine in another project File_Adapter: Create partial class placed in File_Adapter to be moved to File_Engine May 24, 2022
@alelom alelom mentioned this issue May 24, 2022
Merged
alelom added a commit that referenced this issue Dec 14, 2022
@alelom
Merge branch 'main' into File_Adapter-#134-MoveCreateClass
4047f1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alelom alelom

Labels
type:bug Error or unexpected behaviour type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

File_Adapter: Create partial class placed in File_Adapter moved to File_Engine BHoM/File_Toolkit
1 participant
@alelom