Typo in Internalise data button description #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed typo in description.
andrewengh
added
good first issue
|
@BHoMBot check required |
|
@dengh0 to confirm, the following actions are now queued:
There are 193 requests in the queue ahead of you. |
FraserGreenroyd
requested changes
Jul 19, 2022
Updates per PR Co-authored-by: Fraser Greenroyd <[email protected]>
FraserGreenroyd
approved these changes
Jul 21, 2022
There was a problem hiding this comment.
This looks great now, thanks @dengh0
Only thing that will need fixing before merge is the PR title - it shouldn't contain the Excel_UI-#352 element (see here for guidelines), and an appropriate label depicting the type of PR this is (also for the change log). I'd recommend type:documentation based on the code changes. Then the last 2 checks can be triggered and it's good to go.
andrewengh
changed the title
|
@dengh0 to confirm, the following actions are now queued:
|
|
@BHoMBot check ready-to-merge |
|
@dengh0 to confirm, the following actions are now queued:
|
FraserGreenroyd
deleted the
Excel_UI-#352-Typo-in-Internalise-data-button-description
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #352
When hovering over the 'Internalise data' button in the excel bhom UI ribbon, the description of the button contains a typo. Currently says, 'Save the value of the selected cells so it will stil lbe available when the file is reopened.' Needs to be changed to 'Save the value of the selected cells so it will still be available when the file is reopened.'
Test files
None
Changelog
GetCustomUI()- Typo addressedAdditional comments