Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed documentation compliance #68

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

Tom-Kingstone
Copy link
Contributor

NOTE: Depends on

Issues addressed by this PR

Closes #66

fixed input/output attributes being out of order for some methods. Also added attributes to ListToText.

Test files

Changelog

Additional comments

@Tom-Kingstone Tom-Kingstone added the type:compliance Non-conforming to code guidelines label Apr 2, 2024
@Tom-Kingstone Tom-Kingstone self-assigned this Apr 2, 2024
@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check compliance

Copy link

bhombot-ci bot commented Apr 2, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 7 requests in the queue ahead of you.

@Tom-Kingstone
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check compliance

Copy link

bhombot-ci bot commented Apr 2, 2024

@Tom-Kingstone to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 36 requests in the queue ahead of you.

Copy link

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good now, thanks @Tom-Kingstone - approving based on code review.

@FraserGreenroyd
Copy link

@BHoMBot check required

Copy link

bhombot-ci bot commented Apr 2, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 3 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Apr 2, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Apr 2, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Apr 2, 2024

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

@FraserGreenroyd
Copy link

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Apr 2, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit 38d387a into develop Apr 2, 2024
12 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Excel_Toolkit-#66-DocumentationCompliance branch April 2, 2024 10:50
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix documentation compliance
2 participants