Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary using which is preventing ZeroCodeTool build #55

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

FraserGreenroyd
Copy link

@FraserGreenroyd FraserGreenroyd commented Jan 15, 2024

Fixes issue where ZeroCodeTool config cannot build for Nugets

@FraserGreenroyd FraserGreenroyd added the type:bug Error or unexpected behaviour label Jan 15, 2024
@FraserGreenroyd FraserGreenroyd self-assigned this Jan 15, 2024
@FraserGreenroyd
Copy link
Author

@BHoMBot check core

Copy link

bhombot-ci bot commented Jan 15, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core

@FraserGreenroyd
Copy link
Author

@BHoMBot check compliance

Copy link

bhombot-ci bot commented Jan 15, 2024

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

Copy link

@CKBoulter CKBoulter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File changes resolves issue where ZeroCodeTool config cannot build for Nugets.

Copy link

bhombot-ci bot commented Jan 15, 2024

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is core.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 20506745722

@FraserGreenroyd
Copy link
Author

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 20506745722

Copy link

bhombot-ci bot commented Jan 15, 2024

@FraserGreenroyd I have now provided a passing check on reference 20506745722 as requested.

@FraserGreenroyd
Copy link
Author

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: installer, null-handling, serialisation, ready-to-merge, versioning

Copy link

bhombot-ci bot commented Jan 15, 2024

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 5f39031 into develop Jan 15, 2024
11 of 12 checks passed
@FraserGreenroyd FraserGreenroyd deleted the Excel_Toolkit-FixZCTDeployment branch January 15, 2024 20:33
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants