Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Set Get Differential Temp Load #466

Merged
merged 9 commits into from
Dec 10, 2024

Conversation

GCRA101
Copy link
Contributor

@GCRA101 GCRA101 commented Aug 13, 2024

@GCRA101 GCRA101 added the type:feature New capability or enhancement label Aug 13, 2024
@GCRA101 GCRA101 added this to the BHoM 7.3 β MVP milestone Aug 13, 2024
@GCRA101 GCRA101 self-assigned this Aug 13, 2024
Chrisshort92
Chrisshort92 previously approved these changes Aug 30, 2024
Copy link
Contributor

@Chrisshort92 Chrisshort92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality tested against the test script provided. Working as expected. PR Approved

@Chrisshort92
Copy link
Contributor

@BHoMBot check required

Copy link

bhombot-ci bot commented Aug 30, 2024

@Chrisshort92 to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

@peterjamesnugent
Copy link
Member

This is good, can we raise an issue to Read AreaDifferentialTemperatureLoad and BarDifferentialTemperatureLoad.

@GCRA101
Copy link
Contributor Author

GCRA101 commented Sep 4, 2024

@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Sep 4, 2024

@GCRA101 to confirm, the following actions are now queued:

  • check copyright-compliance

@GCRA101
Copy link
Contributor Author

GCRA101 commented Sep 4, 2024

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Sep 4, 2024

@GCRA101 to confirm, the following actions are now queued:

  • check ready-to-merge

There are 41 requests in the queue ahead of you.

@peterjamesnugent
Copy link
Member

@BHoMBot check installer

Copy link

bhombot-ci bot commented Sep 4, 2024

@peterjamesnugent to confirm, the following actions are now queued:

  • check installer

Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments relating to the transition between BHoM and ETABS differential temperature loads. Happy to discuss, I don't think it needs huge changes some just improvements to make users aware.

Etabs_Adapter/CRUD/Create/Load.cs Show resolved Hide resolved
Etabs_Adapter/CRUD/Create/Load.cs Outdated Show resolved Hide resolved
@peterjamesnugent peterjamesnugent added the status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge label Sep 6, 2024
@peterjamesnugent peterjamesnugent removed this from the BHoM 7.3 β MVP milestone Sep 9, 2024
@peterjamesnugent peterjamesnugent removed the status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge label Oct 1, 2024
@peterjamesnugent peterjamesnugent added this to the BHoM 7.4 β MVP milestone Oct 1, 2024
@GCRA101
Copy link
Contributor Author

GCRA101 commented Oct 28, 2024

@BHoMBot check required

Copy link

bhombot-ci bot commented Oct 28, 2024

@GCRA101 to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 23 requests in the queue ahead of you.

Copy link
Contributor Author

@GCRA101 GCRA101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes incorporated as per comments provided.

@GCRA101
Copy link
Contributor Author

GCRA101 commented Oct 28, 2024

@BHoMBot check copyright-compliance

Copy link

bhombot-ci bot commented Oct 28, 2024

@GCRA101 to confirm, the following actions are now queued:

  • check copyright-compliance

@GCRA101
Copy link
Contributor Author

GCRA101 commented Oct 28, 2024

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Oct 28, 2024

@GCRA101 to confirm, the following actions are now queued:

  • check ready-to-merge

@peterjamesnugent
Copy link
Member

@BHoMBot check to ready-to-merge

Copy link

bhombot-ci bot commented Oct 28, 2024

@peterjamesnugent sorry, I didn't understand.
Was that comment an instruction for me? If so, could you state again what check you would like me to do?
For a list of available instructions, please see this wiki page.

@peterjamesnugent peterjamesnugent dismissed their stale review October 31, 2024 10:58

Changes addressed - will allow someone else to comment on functionality

Copy link
Member

@peterjamesnugent peterjamesnugent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy from the code side, @Chrisshort92 can you do a quick functionality check please.

Two things from the changes @GCRA101 and I have discussed:

  1. Uneven temperature differentials should produce a temperature gradient about the centre of the Bar or Panel and then include a BarUniformTemperatureLoad to shift the temperature gradient;
  2. The appropriate warnings appear when trying to push either BarDifferentialTemperatureLoad or AreaDifferentialTemperatureLoad with more than two profiles.

@GCRA101
Copy link
Contributor Author

GCRA101 commented Nov 18, 2024

@HugoVanLooveren,
thanks a lot for checking the other PRs.
Would you have time to have a look also at this one?

Thanks mate.

Giorgio

@Chrisshort92
Copy link
Contributor

@BHoMBot check installer

Copy link

bhombot-ci bot commented Nov 25, 2024

@Chrisshort92 to confirm, the following actions are now queued:

  • check installer

Copy link

bhombot-ci bot commented Nov 25, 2024

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Contributor

@Chrisshort92 Chrisshort92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality has been tested and verified to be working as expected. Approved for merge

@Chrisshort92
Copy link
Contributor

@BHoMBot check required

Copy link

bhombot-ci bot commented Dec 9, 2024

@Chrisshort92 to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check core
  • check null-handling
  • check serialisation
  • check versioning
  • check installer

There are 1 requests in the queue ahead of you.

Copy link

bhombot-ci bot commented Dec 9, 2024

The check code-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Dec 9, 2024

The check documentation-compliance has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Dec 9, 2024

The check core has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Dec 9, 2024

The check serialisation has already been run previously and recorded as a successful check. This check has not been run again at this time.

@GCRA101
Copy link
Contributor Author

GCRA101 commented Dec 9, 2024

@BHoMBot check ready-to-merge

Copy link

bhombot-ci bot commented Dec 9, 2024

@GCRA101 to confirm, the following actions are now queued:

  • check ready-to-merge

There are 38 requests in the queue ahead of you.

@IsakNaslundBh IsakNaslundBh merged commit 0b799dc into develop Dec 10, 2024
10 checks passed
@IsakNaslundBh IsakNaslundBh deleted the ETABS_Toolkit-#458-AddSetGetDiffTempLoad branch December 10, 2024 08:14
Copy link

bhombot-ci bot commented Dec 10, 2024

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link

bhombot-ci bot commented Dec 10, 2024

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Set/Get Differential Temperature Load
4 participants