-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Set Get Differential Temp Load #466
Add Set Get Differential Temp Load #466
Conversation
Since Area objects have the diffload defined in the 3-3 Axis, the corresponding Type Number is 3...not 2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality tested against the test script provided. Working as expected. PR Approved
@BHoMBot check required |
@Chrisshort92 to confirm, the following actions are now queued:
|
This is good, can we raise an issue to |
@BHoMBot check copyright-compliance |
@GCRA101 to confirm, the following actions are now queued:
|
@BHoMBot check ready-to-merge |
@GCRA101 to confirm, the following actions are now queued:
There are 41 requests in the queue ahead of you. |
@BHoMBot check installer |
@peterjamesnugent to confirm, the following actions are now queued:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments relating to the transition between BHoM and ETABS differential temperature loads. Happy to discuss, I don't think it needs huge changes some just improvements to make users aware.
@BHoMBot check required |
@GCRA101 to confirm, the following actions are now queued:
There are 23 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes incorporated as per comments provided.
@BHoMBot check copyright-compliance |
@GCRA101 to confirm, the following actions are now queued:
|
@BHoMBot check ready-to-merge |
@GCRA101 to confirm, the following actions are now queued:
|
@BHoMBot check to ready-to-merge |
@peterjamesnugent sorry, I didn't understand. |
Changes addressed - will allow someone else to comment on functionality
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy from the code side, @Chrisshort92 can you do a quick functionality check please.
Two things from the changes @GCRA101 and I have discussed:
- Uneven temperature differentials should produce a temperature gradient about the centre of the
Bar
orPanel
and then include aBarUniformTemperatureLoad
to shift the temperature gradient; - The appropriate warnings appear when trying to push either
BarDifferentialTemperatureLoad
orAreaDifferentialTemperatureLoad
with more than two profiles.
@HugoVanLooveren, Thanks mate. Giorgio |
@BHoMBot check installer |
@Chrisshort92 to confirm, the following actions are now queued:
|
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functionality has been tested and verified to be working as expected. Approved for merge
@BHoMBot check required |
@Chrisshort92 to confirm, the following actions are now queued:
There are 1 requests in the queue ahead of you. |
The check |
The check |
The check |
The check |
@BHoMBot check ready-to-merge |
@GCRA101 to confirm, the following actions are now queued:
There are 38 requests in the queue ahead of you. |
The check |
The check |
Issues addressed by this PR
Closes #458
Test files
Grasshopper File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23466-AddSetGetDifferentialTempLoad/Test%20Script.gh?csf=1&web=1&e=R86dQg
ETABS File
https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/02_Pull%20Request/BHoM/ETABS_Toolkit/%23466-AddSetGetDifferentialTempLoad/Test%20Etabs%20Model.EDB?csf=1&web=1&e=OisjcH
Changelog