Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6.1 Deployment #423

Merged
merged 16 commits into from
Mar 28, 2023
Merged

6.1 Deployment #423

merged 16 commits into from
Mar 28, 2023

Conversation

@FraserGreenroyd FraserGreenroyd self-requested a review March 13, 2023 18:11
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check beta-merge-status

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 13, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check beta-merge-status

There are 43 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check beta-merge-status

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 19, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check beta-merge-status

There are 43 requests in the queue ahead of you.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 19, 2023

MERGE REPORT - 2023-03-19 15:10.

ERROR CODE(s):

  • DF001.

DETAILS:

  • This pull request can NOT be merged without one or more of its upstream dependencies being merged. Merging this pull request without dependencies will cause compilation errors in this repository. See the check annotations for more information..

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 19, 2023

Please be advised that the check with reference 12111739689 has more than 50 annotations of notes. API limitations restrict annotations to 50. You may need to rerun this check to obtain the next set when you make changes. At the time of reporting this check, there are 22 additional annotations waiting, made up of 22 errors and 0 warnings.

@Chrisshort92 Chrisshort92 requested a review from hmoubarak March 21, 2023 09:44
@FraserGreenroyd FraserGreenroyd added status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge and removed type:feature New capability or enhancement labels Mar 21, 2023
@hmoubarak
Copy link

The toolkit functionality was tested against the sample scripts. Generally read/write functions are working fine. (Topics 1 to 4 in testing protocol). Panels don't update with geometry but that is expected. Results and their visualisation were spot checked but seemed ok. The code was not reviewed.

@FraserGreenroyd
Copy link
Contributor

While this pull request contains a sufficient review from @hmoubarak, unfortunately it is blocked by the inability to deploy one or more of the repositories higher up in this repositories dependency chain.

If there is sufficient demand, we may be able to look at doing a 6.1 beta patch and include it prior to the 6.2 beta.

I am closing this pull request to tidy up and complete the 6.1 deployment. The work will not be lost, and will be eligible for inclusion in the 6.2 beta if it is not deployed via a beta patch prior to the 6.2 beta.

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the basis of @hmoubarak s testing above.

Happy for changes to be included in beta.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 27, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 27, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance
@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check core

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 27, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance
  • check null-handling
  • check serialisation
  • check core

There are 43 requests in the queue ahead of you.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 28, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Revit_Toolkit

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 28, 2023

@bhombot-ci[bot] just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Revit_Toolkit

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 28, 2023

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is beta-code-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 12305511626

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 28, 2023

FAO: @FraserGreenroyd
@FraserGreenroyd is seeking dispensation on this Pull Request to skip a required check. Please can you provide authorisation for the check to be skipped, or provide assistance as appropriate.

The check they wish to have dispensation on is beta-documentation-compliance.

If you are providing dispensation on this occasion, please reply with:

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 12305513570

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 12305513570

@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am authorising dispensation to be granted on check ref. 12305511626

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 28, 2023

@FraserGreenroyd I have now provided a passing check on reference 12305513570 as requested.

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 28, 2023

@FraserGreenroyd I have now provided a passing check on reference 12305511626 as requested.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 28, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 14 requests in the queue ahead of you.

@FraserGreenroyd FraserGreenroyd added type:feature New capability or enhancement and removed status:do-not-merge For instance, test PR, for discussion, or dependant PRs not ready for merge labels Mar 28, 2023
@FraserGreenroyd
Copy link
Contributor

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: ready-to-merge

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 28, 2023

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@hmoubarak
Copy link

hmoubarak commented Mar 28, 2023 via email

@bhombot-ci
Copy link
Author

bhombot-ci bot commented Mar 28, 2023

@hmoubarak sorry, I didn't understand.
Was that comment an instruction for me? If so, could you state again what check you would like me to do?
For a list of available instructions, please see this wiki page.

@FraserGreenroyd FraserGreenroyd merged commit a91e2a2 into main Mar 28, 2023
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants