-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spring stiffness for BarReleases #394
Fix spring stiffness for BarReleases #394
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs similar change in ToBHoM in order to catch springs - see changes in SAP2000
Push works properly.
thanks @JosefTaylor . Have fixed now! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
axes are switched between pulling and pushing: Push uses XZY, pull uses XYZ- I am not sure which one is right! I think it is XZY.
You are right 🤦♂️ . Have fixed now, thanks for spotting. Also added another section of the script to verify that the order is correct by looking at reactions, and as you stated, XZY looks to be correct. Really confusing with Etabs Left-hand rule with switched orientations between 1 and 2 compared to BHoM (and what I have seen in most other packages). Anyhow, code updated and added a small method over the quite long statement of ?s and :s as I found that a bit hard to read if we look at this again :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works great!
I have this transform matrix in SAP2000; is there a way we could use it to create releases?
|
@BHoMBot check required |
@IsakNaslundBh to confirm, the following checks are now queued:
|
@BHoMBot check copyright-compliance |
@IsakNaslundBh to confirm, the following checks are now queued:
There are 14 requests in the queue ahead of you. |
@IsakNaslundBh to confirm, the following checks are now queued:
|
NOTE: Depends on
Issues addressed by this PR
Closes #393
Makes sure the spring stiffness is picked up by changing the check if a DOF is released from checking if identical to free to instead check if it is not fixed.
Test files
https://burohappold.sharepoint.com/:f:/s/BHoM/Evb6D2Mx5SlCldKS1XidhaUBl2Bi4gJ-lwtbV259ropqFg?e=0sPAc7
Changelog
Additional comments