Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spring stiffness for BarReleases #394

Merged

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Dec 22, 2021

NOTE: Depends on

Issues addressed by this PR

Closes #393

Makes sure the spring stiffness is picked up by changing the check if a DOF is released from checking if identical to free to instead check if it is not fixed.

Test files

https://burohappold.sharepoint.com/:f:/s/BHoM/Evb6D2Mx5SlCldKS1XidhaUBl2Bi4gJ-lwtbV259ropqFg?e=0sPAc7

Changelog

Additional comments

Copy link
Contributor

@JosefTaylor JosefTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs similar change in ToBHoM in order to catch springs - see changes in SAP2000
Push works properly.

@IsakNaslundBh
Copy link
Contributor Author

thanks @JosefTaylor .

Have fixed now!

Copy link
Contributor

@JosefTaylor JosefTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

axes are switched between pulling and pushing: Push uses XZY, pull uses XYZ- I am not sure which one is right! I think it is XZY.

@IsakNaslundBh
Copy link
Contributor Author

axes are switched between pulling and pushing: Push uses XZY, pull uses XYZ- I am not sure which one is right! I think it is XZY.

You are right 🤦‍♂️ . Have fixed now, thanks for spotting.

Also added another section of the script to verify that the order is correct by looking at reactions, and as you stated, XZY looks to be correct. Really confusing with Etabs Left-hand rule with switched orientations between 1 and 2 compared to BHoM (and what I have seen in most other packages).

Anyhow, code updated and added a small method over the quite long statement of ?s and :s as I found that a bit hard to read if we look at this again :)

Copy link
Contributor

@JosefTaylor JosefTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great!

@JosefTaylor
Copy link
Contributor

JosefTaylor commented Jan 5, 2022

I have this transform matrix in SAP2000; is there a way we could use it to create releases?

public static TransformMatrix barLocalAxisToBHoM = new TransformMatrix()
        {
            Matrix = new double[4, 4]
            {
                { 1,  0,  0, 0 },
                { 0,  0, -1, 0 },
                { 0,  1,  0, 0 },
                { 0,  0,  0, 1 }
            }
        };

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 11, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 11, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • copyright-compliance

There are 14 requests in the queue ahead of you.

@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check copyright-compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 11, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • copyright-compliance
  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • installer
  • versioning

@IsakNaslundBh IsakNaslundBh merged commit 1c94273 into main Jan 11, 2022
@IsakNaslundBh IsakNaslundBh deleted the ETABS_Toolkit-#393-FixSPringStiffnessForBarReleases branch January 11, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug Error or unexpected behaviour
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stiffness of BarReleases is not correctly assigned to the ETABS model
2 participants