Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the dispatching done by the Update method #326

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Fix the dispatching done by the Update method #326

merged 1 commit into from
Jun 18, 2020

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh added the type:bug Error or unexpected behaviour label Jun 17, 2020
@IsakNaslundBh IsakNaslundBh added this to the BHoM 3.2 β RC milestone Jun 17, 2020
@IsakNaslundBh IsakNaslundBh self-assigned this Jun 17, 2020
@IsakNaslundBh
Copy link
Contributor Author

/azp run ETABS_Toolkit.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

JosefTaylor
JosefTaylor approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@JosefTaylor JosefTaylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update works for bars, panels, and section properties (move doesn't work for panels, which is known), etc., however material properties throw the error '1. Delete for objects of type Steel is not implemented in ETABS17Adapter.' or as relevant for the material type. Not sure if this is a known issue, so I'm approving so that y'all can get to it tomorrow morning, but if this is a bug please fix!

@JosefTaylor
Copy link
Contributor

@IsakNaslundBh There's an issue with this, I wanted to be sure you know before merging, but also wanted to be sure you can merge before I wake up if it's OK

@IsakNaslundBh
Copy link
Contributor Author

Hmm, all working fine for me. Unless something else urgent needs fixing on ETABS, I will leave this open until you come online, and we can check together.

@JosefTaylor
Copy link
Contributor

Issue resolved, was my fault!

@IsakNaslundBh IsakNaslundBh merged commit 9ce8ba2 into master Jun 18, 2020
@IsakNaslundBh IsakNaslundBh deleted the ETABS_Toolkit-FixUpdateDispatching branch June 18, 2020 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JosefTaylor JosefTaylor JosefTaylor approved these changes

@alelom alelom Awaiting requested review from alelom

@kThorsager kThorsager Awaiting requested review from kThorsager

Assignees

@IsakNaslundBh IsakNaslundBh

Labels
type:bug Error or unexpected behaviour
Projects
None yet
Milestone
BHoM 3.2 β RC
Development

Successfully merging this pull request may close these issues.

ETABS_Toolkit: Update is not dispatching properly for some types
2 participants
@IsakNaslundBh @JosefTaylor