Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ETABS_Toolkit: Remove Common_Engine reference #302

Merged

Conversation

kThorsager
Copy link
Contributor

Issues addressed by this PR

Closes #291
Removes the common_engine reference as those methods will be removed and updates the using statements to their new location in Spatial_Engine

Test files

Any or none, only changes to references

Changelog

Additional comments

@kThorsager kThorsager added the type:compliance Non-conforming to code guidelines label Apr 16, 2020
@kThorsager kThorsager added this to the BHoM 3.2 β MVP milestone Apr 16, 2020
@kThorsager kThorsager self-assigned this Apr 16, 2020
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All look fine!

@IsakNaslundBh
Copy link
Contributor

/azp run ETABS_Toolkit.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@IsakNaslundBh IsakNaslundBh merged commit 607a37c into master Apr 16, 2020
@IsakNaslundBh IsakNaslundBh deleted the ETABS_Toolkit-#291-Remove-Common_Engine-reference branch April 16, 2020 13:00
@kThorsager kThorsager restored the ETABS_Toolkit-#291-Remove-Common_Engine-reference branch April 16, 2020 14:36
@kThorsager kThorsager deleted the ETABS_Toolkit-#291-Remove-Common_Engine-reference branch April 16, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ETABS_Toolkit: Remove Common_Engine reference
2 participants