Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding virtual keyword to all oM classes #301

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

IsakNaslundBh
Copy link
Contributor

Issues addressed by this PR

Closes #297

remake of #300

  • Adding virtual keyword to all properties
  • Adding some missing documentation lines

Test files

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:compliance Non-conforming to code guidelines label Apr 14, 2020
@IsakNaslundBh IsakNaslundBh self-assigned this Apr 14, 2020
Copy link
Contributor

@kThorsager kThorsager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kThorsager
Copy link
Contributor

/azp run ETABS_Toolkit.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@IsakNaslundBh IsakNaslundBh merged commit 013ae29 into master Apr 15, 2020
@IsakNaslundBh IsakNaslundBh deleted the ETABS_Toolkit-#297-MakePropertiesVirtual2 branch April 15, 2020 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add virtual keyword to oM properties
2 participants