Read ETABS Database sections #281
Conversation
kThorsager
added
type:feature
kThorsager
removed
the
status:WIP
| @@ -73,7 +73,16 @@ private bool CreateObject(ISectionProperty bhSection) | |||
| return true; | |||
| } | |||
|
|
|||
| SetSection(bhSection as dynamic); | |||
| if (!m_DBSectionsNames.Contains(bhSection.Name) || // Does the name not exist in the database or | |||
There was a problem hiding this comment.
As discussed before, will need to name converters here, between BHoM and Etabs standard names, this is at least for all UK Sections.
Some things I have noted (so far) are.
General:
- Etabs uses all capatal casing (ToUpper())
- Etabs does not use spaces (Replace(" ","")
- Etabs does not type out ".0" for no decimals
Then some specifics:
- UB -> UKB
- UC -> UKC
- UPB -> UKPB
- L -> UKA
- PFC -> UKPFC
- CHS -> CHHF
- RHS -> RHHF
- SHS -> SHHF
- TUB -> UKT
- TUC -> UKT
Might want to add some general Convert methods in the adapter to handle this name conversions. All the specifics above holds true for British shapes. For ArcelorMittal_British and ArcelorMittal_BritishHISTAR the UB/UC/UBP names can stay as they are.
There was a problem hiding this comment.
Took a gander through the sections in the BHoM database and the equivalent ones in ETABS database, and as it is now we'll be able to push all of or sections (provided that the dimensions are correct, I'm only fixing the name formatting).
Checked so that our database slots into:
BSShapes2006
AISC14
AISC14M
AISC15
AISC15M
ArcelorMittal_British
ArcelorMittal_BritishHISTAR
and added some pre-formatting on the ETABS section names to facilitate those which have spaces and lowercase letters
|
Or is it to late to merge this @IsakNaslundBh ? It's technically doing compliance as well |
|
/azp run ETABS_Toolkit.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
as the would not be functioning as "old" in either casse
would previously have made UBP into UKBP through replacing UB to UKB, which was technichally fine now, but would give some fun buggs later down the line
and name the section to the original BHoM name, avoids issues with keeping track of the name
FraserGreenroyd
force-pushed
the
Etabs_Toolkit-#141-Read-DB-sections
branch
from
b7fa840 to
c8fb2b0
Compare
|
In a call with @IsakNaslundBh - we have just done a manual rebase fix for this PR to allow it to merge, @IsakNaslundBh will retest (though there should be nothing changed) and re-approve as appropriate 😄 |
|
/azp run ETABS_Toolkit.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Issues addressed by this PR
Closes #141
Closes #106
Closes #278
The ETABS Adapter now checks the database if there is a existing section with the same name, and if there is uses that instead.
The section name set in BHoM will be the name of the section in ETABS, a note will be displayed if a database section is used
ETABS config has also been renamed to EtabsSettings
see also BHoM/Versioning_Toolkit#38 for versioning
Test files
https://burohappold.sharepoint.com/:u:/s/BHoM/EdeaegrojaNOnj_zOCO1B1gBjTzv3BCfo453TlrGXg1aqg?e=Wb7yLu
Changelog
EtabsConfigtoEtabsSettingsAdditional comments