Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log file id and file path #293

Merged

Conversation

adecler
Copy link
Member

@adecler adecler commented Feb 17, 2021

NOTE: Depends on

BHoM/BHoM_Engine#2312
BHoM/BHoM_UI#370

Issues addressed by this PR

Provide changes required for fileName and project code to be saved by analytics.

Test files

Will be tested alongside the BHoMAnalytics PR

@adecler adecler added the type:feature New capability or enhancement label Feb 17, 2021
@adecler adecler added this to the BHoM 4.1 β RC milestone Feb 17, 2021
@adecler
Copy link
Member Author

adecler commented Feb 17, 2021

@BHoMBot check copyright

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 17, 2021

@adecler to confirm, check-copyright-compliance task is now queued.

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 17, 2021

@adecler just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @adecler on BHoM_UI

@adecler adecler self-assigned this Feb 17, 2021
@AndreBalasian
Copy link

Is it possible to log usage by Dynamo scripts that don't contain any BHoM functionality, perhaps by calling some method?
If so, could you recommend a method that doesn't do much, but could be placed in a script for the sake of logging the use of that script file?

@adecler
Copy link
Member Author

adecler commented Feb 18, 2021

Is it possible to log usage by Dynamo scripts that don't contain any BHoM functionality, perhaps by calling some method?
If so, could you recommend a method that doesn't do much, but could be placed in a script for the sake of logging the use of that script file?

@AndreBalasian , The new SetProjectID component from this set of PRs seems to be a good candidate for that. See BHoM/BHoM_UI#370

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 18, 2021

@adecler just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @adecler on BHoM_UI

@adecler adecler requested a review from pawelbaran February 19, 2021 09:58
@pawelbaran
Copy link
Member

I have just tested the PR, looks like it works fine locally (SetProjectID checked, local log creation checked, local log update checked). Could you check if the logs got recorded in the database too, @adecler @al-fisher? ProjectIds are Hey Jude 18 for Revit 2018 + Dynamo 2.0 and Hey Jude 20 for Revit 2020 and Dynamo 2.3 🙈

@adecler
Copy link
Member Author

adecler commented Mar 5, 2021

Could you check if the logs got recorded in the database too, @adecler @al-fisher? ProjectIds are Hey Jude 18 for Revit 2018 + Dynamo 2.0 and Hey Jude 20 for Revit 2020 and Dynamo 2.3 🙈

Yes, they are showing in the database. Thanks @pawelbaran

Copy link
Member

@pawelbaran pawelbaran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving then, the code LGTM 👍

@pawelbaran pawelbaran merged commit 7bef015 into master Mar 5, 2021
@pawelbaran pawelbaran deleted the BHoMAnalytics_Toolkit-#15-SaveFileNameAndProjectCode branch March 5, 2021 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants