Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Assembly Version #33

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Update Assembly Version #33

merged 1 commit into from
Mar 29, 2021

Conversation

BHoMBot
Copy link
Member

@BHoMBot BHoMBot commented Mar 26, 2021

Closes #32

FraserGreenroyd
FraserGreenroyd approved these changes Mar 26, 2021
View reviewed changes
Copy link

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed from a CI/CD perspective. Will let discipline merge when happy.

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Mar 26, 2021
@bhombot-ci
Copy link

bhombot-ci bot commented Mar 26, 2021

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 26, 2021

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Plaxis_Toolkit

@rolyhudson
Copy link

@BHoMBot check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Mar 29, 2021

@rolyhudson to confirm, check-copyright-compliance task is now queued.

rolyhudson
rolyhudson approved these changes Mar 29, 2021
View reviewed changes
Copy link

@rolyhudson rolyhudson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rolyhudson rolyhudson merged commit ab34f9d into master Mar 29, 2021
@rolyhudson rolyhudson deleted the BHoMBot-UpdateAssemblyVersion branch March 29, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@rolyhudson rolyhudson rolyhudson approved these changes

Assignees
No one assigned
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update AssemblyFileVersion
3 participants
@BHoMBot @rolyhudson @FraserGreenroyd