Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of methods being migrated to LifeCycleAssessment_Toolkit #76

Merged
merged 1 commit into from
May 28, 2020
Merged

Removal of methods being migrated to LifeCycleAssessment_Toolkit #76

merged 1 commit into from
May 28, 2020

Conversation

michaelhoehn
Copy link
Contributor

@michaelhoehn michaelhoehn commented May 28, 2020 •
edited
Loading

NOTE: Depends on

Issues addressed by this PR

Closes #57

Test files

Changelog

Additional comments

Methods migrated to LifeCycleAssessment_Toolkit:

  • CalulateAssemblies\ConcreteVolume
  • CalulateAssemblies\GlazingVolume
  • CalulateAssemblies\ReinforcementVolume
  • EmbodiedEnergyVariance
  • MaterialEndOfLifeTreatment
  • All Environmental Product Declaration-related evaluation methods (globalWarmingPotential etc..)

@michaelhoehn michaelhoehn self-assigned this May 28, 2020
@michaelhoehn
Copy link
Contributor Author

/azp run ClimateEmergency_Toolkit.CheckInstaller

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@michaelhoehn
Copy link
Contributor Author

/azp run ClimateEmergency_Toolkit.CheckCompliance

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@michaelhoehn michaelhoehn changed the title Removal of methods being migrated Removal of methods being migrated to LifeCycleAssessment_Toolkit May 28, 2020
@FraserGreenroyd FraserGreenroyd merged commit 2a2e6d4 into master May 28, 2020
@FraserGreenroyd FraserGreenroyd deleted the ClimateEmergency_Toolkit-#57-Migrate-to-LCA_Toolkit branch May 28, 2020 22:30
@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Jun 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@kayleighhoude kayleighhoude Awaiting requested review from kayleighhoude

Assignees

@michaelhoehn michaelhoehn

Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate all methods to LifeCycleAssessment_Toolkit
2 participants
@michaelhoehn @FraserGreenroyd