Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove API Token method for Security #111

Merged
merged 2 commits into from
Jun 16, 2023

Conversation

FraserGreenroyd
Copy link

Fixes #110

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Jun 16, 2023
@FraserGreenroyd FraserGreenroyd self-assigned this Jun 16, 2023
@FraserGreenroyd
Copy link
Author

@BHoMBot check versioning
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 16, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning
  • check installer

There are 1 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 16, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 3 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 16, 2023

@FraserGreenroyd fix requested for project compliance.

The errors with the CSProject (.csproj) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix project file ref. 14322567065

@FraserGreenroyd
Copy link
Author

@BHoMBot fix project file ref. 14322567065

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 16, 2023

@FraserGreenroyd I have queued up your request to fix the csproj file(s). There are 2 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 16, 2023

@FraserGreenroyd I am now going to fix the project compliance in accordance with the annotations previously made.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 16, 2023

@FraserGreenroyd to confirm I have now resolved the project compliance issues and pushed a commit to this Pull Request.

@FraserGreenroyd
Copy link
Author

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 16, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

There are 2 requests in the queue ahead of you.

Copy link

@travispotterBH travispotterBH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense, doesn't appear to break functionality. 👍

@FraserGreenroyd
Copy link
Author

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation
@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 16, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation
  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit ee7cae1 into develop Jun 16, 2023
@FraserGreenroyd FraserGreenroyd deleted the CarbonQueryDatabase_Toolkit-#110-Security branch June 16, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security issue - component taking passwords
3 participants