Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update convert method to compile with changes to LCA_oM #106

Conversation

IsakNaslundBh
Copy link
Contributor

NOTE: Depends on

BHoM/BHoM#1498

Issues addressed by this PR

Make toolkit compile and work with changes to LCA_oM

Test files

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added the type:external-api-changes Imposed changes, including from dependency across other BHoM repos label May 23, 2023
@IsakNaslundBh IsakNaslundBh self-assigned this May 23, 2023
@bhombot-ci
Copy link

bhombot-ci bot commented May 23, 2023

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 2, 2023

@IsakNaslundBh just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Jun 2, 2023

@IsakNaslundBh just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 2, 2023

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM

@adecler
Copy link
Member

adecler commented Jun 2, 2023

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 2, 2023

@adecler to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 2, 2023

@IsakNaslundBh just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @adecler on BHoM

@adecler adecler self-requested a review June 3, 2023 09:26
Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving from a code perspective
Will also have to be reviewed and approved from a user perspective.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 3, 2023

@IsakNaslundBh just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 3, 2023

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Jun 4, 2023

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd
Copy link

@BHoMBot check core
@BHoMBot check serialisation
@BHoMBot check null-handling

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 4, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check serialisation
  • check null-handling

There are 3 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jun 4, 2023

@IsakNaslundBh just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on LifeCycleAssessment_Toolkit

@FraserGreenroyd FraserGreenroyd merged commit 660885c into develop Jun 4, 2023
@FraserGreenroyd FraserGreenroyd deleted the LifeCycleAssessment_oM-#1493-RefactorEPDAndResultClasses branch June 4, 2023 00:48
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants