Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update version of CompilerServices.Unsafe to 5.0.0 #54

Merged
merged 1 commit into from
Nov 24, 2022

Conversation

adecler
Copy link
Member

@adecler adecler commented Nov 23, 2022

Issues addressed by this PR

Related to BHoM/BHoM_Engine#2948

The new version of the Mongo Bson NuGet package is now using version 5 of CompilerServices.Unsafe. So we need to make sure it is kept consistent across all repos.

@adecler adecler added the type:external-api-changes Imposed changes, including from dependency across other BHoM repos label Nov 23, 2022
@adecler adecler self-assigned this Nov 23, 2022
@adecler
Copy link
Member Author

adecler commented Nov 23, 2022

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2022

@adecler to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2022

@adecler just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on File_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2022

@adecler just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on File_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2022

@adecler just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on File_Toolkit

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check core
@BHoMBot check null-handling
@BHoMBot check serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 23, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check null-handling
  • check serialisation

There are 28 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Nov 24, 2022

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

There are 6 requests in the queue ahead of you.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving based on the reviews for the dependant works in this series.

@FraserGreenroyd FraserGreenroyd merged commit 26fef2f into main Nov 24, 2022
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Engine-#2948-UpgradeMongo branch November 24, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:external-api-changes Imposed changes, including from dependency across other BHoM repos
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants