Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Copyright Header to 2021 #39

Merged
merged 1 commit into from
Jan 5, 2021
Merged

Update Copyright Header to 2021 #39

merged 1 commit into from
Jan 5, 2021

Conversation

BHoMBot
Copy link
Member

@BHoMBot BHoMBot commented Jan 4, 2021

Closes #38

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 4, 2021

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Jan 4, 2021

@BHoMBot just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check copyright compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 4, 2021

@FraserGreenroyd to confirm, check-copyright-compliance task is now queued.

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Jan 4, 2021
FraserGreenroyd
FraserGreenroyd approved these changes Jan 4, 2021
View reviewed changes
Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will leave for discipline review/merge within the next 5 days.

adecler
adecler previously requested changes Jan 5, 2021
View reviewed changes
Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested programmatically with this script. One file needs fixing:

C:\Users\adecler\OneDrive - BuroHappold\Documents\GitHub\CSharp_Toolkit\CSharp_Engine\Compute\Compile.cs

The copyright date was not updated to 2021.

@adecler adecler dismissed their stale review January 5, 2021 03:00

Uncommited file was included in the check

adecler
adecler approved these changes Jan 5, 2021
View reviewed changes
Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested programmatically with this script.

All looks good

@adecler adecler merged commit fafc967 into master Jan 5, 2021
@adecler adecler deleted the BHoMBot-UpdateCopyright2021 branch January 5, 2021 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

@adecler adecler adecler approved these changes

Assignees
No one assigned
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compliance of BHoM file Copyright Headers
3 participants
@BHoMBot @FraserGreenroyd @adecler