Do not copy languages packages to ProgramData #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adecler
added
the
type:external-api-changes
FraserGreenroyd
changed the title
FraserGreenroyd
approved these changes
Jun 9, 2020
|
/azp run CSharp_Toolkit.CheckInstaller |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues addressed by this PR
Closes #16
A series of localisation folders are copied over to ProgramData. After a few tests, they didn't look necessary with the current state of the CSharp toolkit.
So I suggest we drop them for now. I prefer to add them only if they become needed due to new features in the CSharp toolkit.
Test files
Just make sure that the
ToCSharpTextcomponent is still working once you have deleted those language folders.You can use this file if you don't have one: https://burohappold.sharepoint.com/:u:/r/sites/BHoM/02_Current/12_Scripts/01_Test%20Scripts/CSharp_Toolkit/Node2CodeTest.gh?csf=1&web=1&e=IVWDKG