Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update repo ReadMe.md file #22

Merged
merged 4 commits into from
May 16, 2020
Merged

Update repo ReadMe.md file #22

merged 4 commits into from
May 16, 2020

Conversation

adecler
Copy link
Member

@adecler adecler commented May 16, 2020

Issues addressed by this PR

Closes #21

@adecler adecler added the type:documentation Wiki, help or in code attributes label May 16, 2020
@adecler adecler added this to the BHoM 3.2 β MVP milestone May 16, 2020
@adecler adecler requested a review from FraserGreenroyd May 16, 2020 09:11
@adecler adecler self-assigned this May 16, 2020
FraserGreenroyd
FraserGreenroyd requested changes May 16, 2020
View reviewed changes
README.md Outdated
@@ -1,54 +1,27 @@
[![License: LGPL v3](https://img.shields.io/badge/License-LGPL%20v3-blue.svg)](https://www.gnu.org/licenses/lgpl-3.0)
# BHoM
[![License: LGPL v3](https://img.shields.io/badge/License-LGPL%20v3-blue.svg)](https://www.gnu.org/licenses/lgpl-3.0) [![Build status](https://ci.appveyor.com/api/projects/status/my3nfqs186bkh325/branch/master?svg=true)](https://ci.appveyor.com/api/projects/status/csharp_toolkit/branch/master) [![Build Status](https://dev.azure.com/BHoMBot/BHoM/_apis/build/status/CSharp_Toolkit/CSharp_Toolkit.CheckCore?branchName=master)](https://dev.azure.com/BHoMBot/BHoM/_build/latest?definitionId=9176&branchName=master)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Azure badge should be [![Build Status](https://dev.azure.com/BHoMBot/BHoM/_apis/build/status/CSharp_Toolkit/CSharp_Toolkit.CheckCore?branchName=master)](https://dev.azure.com/BHoMBot/BHoM/_build/latest?definitionId=174&branchName=master)

@FraserGreenroyd
Copy link
Contributor

Also not sure about the CI checks on AppVeyor. They're not happy but this PR doesn't change anything functional with the code. I would say it warrants investigation, but I'm not thinking this PR is the scope to fix whatever they're complaining about given this PR is about the ReadMe only.

@adecler adecler requested a review from FraserGreenroyd May 16, 2020 10:42
@FraserGreenroyd FraserGreenroyd mentioned this pull request May 16, 2020
Closed
@FraserGreenroyd
Copy link
Contributor

I've raised this issue to investigate the CI issue, this PR can be merged by someone with merge rights based on the approval above 😄

@al-fisher
Copy link
Member

Yep happy to merge as this is an isolated AppVeyor issue - and not this PR

@al-fisher al-fisher merged commit d5a3596 into master May 16, 2020
@al-fisher al-fisher deleted the CSharp_Toolkit-#21-UpdateReadme branch May 16, 2020 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FraserGreenroyd FraserGreenroyd FraserGreenroyd approved these changes

Assignees

@adecler adecler

Labels
type:documentation Wiki, help or in code attributes
Projects
None yet
Milestone
BHoM 3.2 β MVP
Development

Successfully merging this pull request may close these issues.

Update repo ReadMe.md file
3 participants
@adecler @FraserGreenroyd @al-fisher