Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BHoM_UI: New boolean toggle component #472

Merged
merged 9 commits into from
Oct 3, 2023

Conversation

albinber
Copy link
Contributor

@albinber albinber commented Oct 2, 2023

NOTE: Depends on

Issues addressed by this PR

Closes #

Test files

Changelog

Additional comments

@albinber albinber added the type:feature New capability or enhancement label Oct 2, 2023
@albinber albinber self-assigned this Oct 2, 2023
BHoM_UI/Components/UI/FalseStartToggle.cs Outdated Show resolved Hide resolved
BHoM_UI/Components/UI/FalseStartToggle.cs Outdated Show resolved Hide resolved
BHoM_UI/Components/UI/FalseStartToggle.cs Outdated Show resolved Hide resolved
BHoM_UI/Components/UI/FalseStartToggle.cs Outdated Show resolved Hide resolved
BHoM_UI/Components/UI/FalseStartToggle.cs Outdated Show resolved Hide resolved
@FraserGreenroyd
Copy link
Contributor

@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 3, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 3, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

There are 4 requests in the queue ahead of you.

@FraserGreenroyd
Copy link
Contributor

@BHoMBot check installer
@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 3, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check installer
  • check core

There are 1 requests in the queue ahead of you.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

This looks great @albinber , great work and great team-work/collaboration on this.

I've reviewed the code and that looks fine.

I've tested in Grasshopper by setting a few components on the canvas, saving, and reopening the script and the components load in defaulting to false.

Happy to deploy to alphas.

@Tom-Kingstone Tom-Kingstone self-requested a review October 3, 2023 15:26
Copy link
Contributor

@Tom-Kingstone Tom-Kingstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
Tested on loading, and any toggles that were true are set to false, good job @albinber

@bhombot-ci
Copy link

bhombot-ci bot commented Oct 3, 2023

@albinber just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on Grasshopper_UI

@FraserGreenroyd FraserGreenroyd merged commit f80cb6c into develop Oct 3, 2023
@FraserGreenroyd FraserGreenroyd deleted the BHoM_UI-#684-NewToggleForBHoM branch October 3, 2023 16:50
@bhombot-ci bhombot-ci bot mentioned this pull request Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants