Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compile against BHoM_Engine change of InputExposure file location #457

Merged
merged 1 commit into from
May 22, 2023

Conversation

FraserGreenroyd
Copy link
Contributor

NOTE: Depends on

BHoM/BHoM_Engine#3054

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label May 19, 2023
@FraserGreenroyd FraserGreenroyd self-assigned this May 19, 2023
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check copyright-compliance
@BHoMBot check project-compliance
@BHoMBot check core

@bhombot-ci
Copy link

bhombot-ci bot commented May 19, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check copyright-compliance
  • check project-compliance
  • check core

There are 10 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented May 19, 2023

@FraserGreenroyd just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

@bhombot-ci
Copy link

bhombot-ci bot commented May 19, 2023

@FraserGreenroyd just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

@bhombot-ci
Copy link

bhombot-ci bot commented May 19, 2023

@FraserGreenroyd just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented May 20, 2023

@FraserGreenroyd just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

@bhombot-ci
Copy link

bhombot-ci bot commented May 20, 2023

@FraserGreenroyd just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy with change here, just additional using.

Tested with linked Engine PR.

@bhombot-ci
Copy link

bhombot-ci bot commented May 22, 2023

@FraserGreenroyd just to let you know, I have provided a check-ready-to-merge result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

@FraserGreenroyd FraserGreenroyd merged commit f2c378b into develop May 22, 2023
@FraserGreenroyd FraserGreenroyd deleted the BHoM_Engine-#3053-UpdateMethodParamDisplay branch May 22, 2023 11:07
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants