Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilise Exposure in ParamInfo #456

Merged
merged 2 commits into from
May 19, 2023

Conversation

FraserGreenroyd
Copy link
Contributor

Fixes #455

This provides the UIExposure information to the ParamInfo object used by all UIs downstream.

Each UI will be responsible for handling how they opt to display or not display something with IsExposed = false depending on each UIs requirements.

@FraserGreenroyd FraserGreenroyd added the type:feature New capability or enhancement label May 18, 2023
@FraserGreenroyd FraserGreenroyd self-assigned this May 18, 2023
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check versioning
@BHoMBot check project-compliance
@BHoMBot check copyright-compliance
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented May 18, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check versioning
  • check project-compliance
  • check copyright-compliance
  • check installer

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check versioning

@bhombot-ci
Copy link

bhombot-ci bot commented May 18, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check versioning

UI_oM/ParamInfo.cs Outdated Show resolved Hide resolved
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check core
@BHoMBot check versioning
@BHoMBot check project-compliance
@BHoMBot check copyright-compliance
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented May 19, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check core
  • check versioning
  • check project-compliance
  • check copyright-compliance
  • check installer

There are 5 requests in the queue ahead of you.

Copy link
Contributor

@IsakNaslundBh IsakNaslundBh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in grasshopper with example method.

        [Description("Queries the centre of area enclosed by a closed, planar, non-self-intersecting Polyline.")]
        [Input("curve", "The Polyline to get the centre of area of.")]
        [Input("tolerance", "Distance tolerance used in geometry processing, default set to BH.oM.Geometry.Tolerance.Distance.", typeof(Length))]
        [Input("validateInput", "Toggels whether checks on the input geometry should be run or not, defaulting to true.", oM.Base.Attributes.Enums.UIExposure.Hidden)]
        [Output("centroid", "The Point at the centre of a region enclosed by given Polyline.")]
        public static Point Centroid(this IPolyline curve, double tolerance = Tolerance.Distance, bool validateInput = true)
        {
...

And functions as intended.

Only comment, as discussed offline, is regarding how the method shows up in menu-selection, both global search and right-click menu on component. As discussed this will be tackled by BHoM/BHoM_Engine#3053

Code changes also are small and makes sense.

With all this, happy to approve.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented May 19, 2023

@FraserGreenroyd to confirm, the following actions are now queued:

  • check ready-to-merge

@FraserGreenroyd FraserGreenroyd merged commit b5ff73e into develop May 19, 2023
@FraserGreenroyd FraserGreenroyd deleted the BHoM_UI-#455-UtiliseUIExposure branch May 19, 2023 13:15
@bhombot-ci bhombot-ci bot mentioned this pull request Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Utilise UIExposure on method inputs
2 participants