-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Utilise Exposure in ParamInfo #456
Conversation
@FraserGreenroyd to confirm, the following actions are now queued:
|
@BHoMBot check versioning |
@FraserGreenroyd to confirm, the following actions are now queued:
|
@FraserGreenroyd to confirm, the following actions are now queued:
There are 5 requests in the queue ahead of you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested in grasshopper with example method.
[Description("Queries the centre of area enclosed by a closed, planar, non-self-intersecting Polyline.")]
[Input("curve", "The Polyline to get the centre of area of.")]
[Input("tolerance", "Distance tolerance used in geometry processing, default set to BH.oM.Geometry.Tolerance.Distance.", typeof(Length))]
[Input("validateInput", "Toggels whether checks on the input geometry should be run or not, defaulting to true.", oM.Base.Attributes.Enums.UIExposure.Hidden)]
[Output("centroid", "The Point at the centre of a region enclosed by given Polyline.")]
public static Point Centroid(this IPolyline curve, double tolerance = Tolerance.Distance, bool validateInput = true)
{
...
And functions as intended.
Only comment, as discussed offline, is regarding how the method shows up in menu-selection, both global search and right-click menu on component. As discussed this will be tackled by BHoM/BHoM_Engine#3053
Code changes also are small and makes sense.
With all this, happy to approve.
@BHoMBot check ready-to-merge |
@FraserGreenroyd to confirm, the following actions are now queued:
|
Fixes #455
This provides the UIExposure information to the
ParamInfo
object used by all UIs downstream.Each UI will be responsible for handling how they opt to display or not display something with
IsExposed = false
depending on each UIs requirements.