Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enum.GetNames replaced with IToText on enum label generation to leverage DisplayText attribute #448

Merged
merged 3 commits into from
Feb 16, 2023

Conversation

pawelbaran
Copy link
Member

Issues addressed by this PR

Closes #447

Test files

Create DensityExtractionType enum in Grasshopper and see if the first option shows as AllMatching (current) or All matching. (desired).

Changelog

Additional comments

@pawelbaran pawelbaran added the type:feature New capability or enhancement label Feb 15, 2023
@pawelbaran pawelbaran requested a review from adecler February 15, 2023 14:15
@pawelbaran pawelbaran self-assigned this Feb 15, 2023
Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @pawelbaran ,

The code change makes sense and we now have the expected behaviour in the UI:
image

@pawelbaran
Copy link
Member Author

@BHoMBot check core
@BHoMBot check compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 15, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check core
  • check code-compliance
  • check documentation-compliance
  • check project-compliance
  • check branch-compliance
  • check dataset-compliance
  • check copyright-compliance

@pawelbaran
Copy link
Member Author

@BHoMBot check versioning
@BHoMBot check installer

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 15, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check versioning
  • check installer

@pawelbaran
Copy link
Member Author

@BHoMBot check ready-to-merge

@bhombot-ci
Copy link

bhombot-ci bot commented Feb 15, 2023

@pawelbaran to confirm, the following actions are now queued:

  • check ready-to-merge

@adecler adecler merged commit d261996 into develop Feb 16, 2023
@adecler adecler deleted the BHoM_UI-#447-UseDisplayTextInEnumLabels branch February 16, 2023 09:10
@bhombot-ci bhombot-ci bot mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pick DisplayText attribute of enums while generating their labels
2 participants