Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for single matching input for Create method replacement of Type #414

Merged

Conversation

IsakNaslundBh
Copy link
Contributor

@IsakNaslundBh IsakNaslundBh commented Jan 21, 2022

NOTE: Depends on

Done in support of https://github.com/BHoM/BHoM_Engine/pull/2738/files but does not require that to compile.

Issues addressed by this PR

Adding support for single type matching of inputs to be replaced when going from Create method to PropertyAssignment create method. This is what is done on the updates side, so should be a simple alignment with what is done there.

Test files

Changelog

Additional comments

@IsakNaslundBh IsakNaslundBh added type:compliance Non-conforming to code guidelines type:feature New capability or enhancement labels Jan 21, 2022
@IsakNaslundBh IsakNaslundBh self-assigned this Jan 21, 2022
@bhombot-ci
Copy link

bhombot-ci bot commented Jan 24, 2022

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine

2 similar comments
@bhombot-ci
Copy link

bhombot-ci bot commented Jan 24, 2022

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 24, 2022

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 24, 2022

@IsakNaslundBh just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine

1 similar comment
@bhombot-ci
Copy link

bhombot-ci bot commented Jan 24, 2022

@IsakNaslundBh just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 24, 2022

@IsakNaslundBh just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @IsakNaslundBh on BHoM_Engine

@IsakNaslundBh IsakNaslundBh changed the title Add support for single matching input for Create method replacement o… Add support for single matching input for Create method replacement of Type Jan 24, 2022
@IsakNaslundBh IsakNaslundBh marked this pull request as ready for review January 24, 2022 15:57
@IsakNaslundBh
Copy link
Contributor Author

@BHoMBot check compliance
@BHoMBot check required

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 24, 2022

@IsakNaslundBh to confirm, the following checks are now queued:

  • code-compliance
  • documentation-compliance
  • project-compliance
  • branch-compliance
  • dataset-compliance
  • copyright-compliance
  • code-compliance
  • documentation-compliance
  • project-compliance
  • core
  • null-handling
  • serialisation
  • versioning
  • installer

There are 116 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 24, 2022

The check versioning has already been run previously and recorded as a successful check. This check has not been run again at this time.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 24, 2022

The check installer has already been run previously and recorded as a successful check. This check has not been run again at this time.

Copy link
Contributor

@FraserGreenroyd FraserGreenroyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have run through with @IsakNaslundBh and am happy the addition to the code base allows parameter matching by data type in the instance where the parameter name has changed. Works for the use case described.

@FraserGreenroyd FraserGreenroyd merged commit c031e46 into main Jan 25, 2022
@FraserGreenroyd FraserGreenroyd deleted the Structure_Engine-#2736-CleanUpToBeRemovedMethod branch January 25, 2022 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines type:feature New capability or enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants