-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for single matching input for Create method replacement of Type #414
Add support for single matching input for Create method replacement of Type #414
Conversation
@IsakNaslundBh just to let you know, I have provided a |
2 similar comments
@IsakNaslundBh just to let you know, I have provided a |
@IsakNaslundBh just to let you know, I have provided a |
@IsakNaslundBh just to let you know, I have provided a |
1 similar comment
@IsakNaslundBh just to let you know, I have provided a |
@IsakNaslundBh just to let you know, I have provided a |
@IsakNaslundBh to confirm, the following checks are now queued:
There are 116 requests in the queue ahead of you. |
The check |
The check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have run through with @IsakNaslundBh and am happy the addition to the code base allows parameter matching by data type in the instance where the parameter name has changed. Works for the use case described.
NOTE: Depends on
Done in support of https://github.com/BHoM/BHoM_Engine/pull/2738/files but does not require that to compile.
Issues addressed by this PR
Adding support for single type matching of inputs to be replaced when going from Create method to PropertyAssignment create method. This is what is done on the updates side, so should be a simple alignment with what is done there.
Test files
Changelog
Additional comments