Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align with changes in oM and Engine on Reflection -> Base #413

Merged
merged 4 commits into from
Jan 13, 2022

Conversation

FraserGreenroyd
Copy link
Contributor

NOTE: Depends on

BHoM/BHoM#1339
BHoM/BHoM_Engine#2729

Issues addressed by this PR

Test files

Changelog

Additional comments

@FraserGreenroyd FraserGreenroyd added the type:compliance Non-conforming to code guidelines label Jan 11, 2022
@FraserGreenroyd FraserGreenroyd self-assigned this Jan 11, 2022
@bhombot-ci
Copy link

bhombot-ci bot commented Jan 12, 2022

@FraserGreenroyd just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 12, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • project-compliance

There are 2 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 12, 2022

@FraserGreenroyd fix requested for project compliance.

The errors with the CSProject (.csproj) files have been recorded as annotations on the checks tab.

I will apply the fixes to every case detailed on the checks tab with the exception of any references to the target framework. I am unable to provide fixes to the Target Framework automatically, these will need to be performed manually. If you want to perform the fixes in a different manner please resolve this manually and rerun the check.

If you are happy for me to go ahead and perform this action, please reply with:

@BHoMBot fix project file ref. 4788179936

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot fix project file ref. 4788179936

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 12, 2022

@FraserGreenroyd I am now going to fix the CSProject compliance in accordance with the annotations previously made.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 12, 2022

@FraserGreenroyd to confirm I have now resolved the CSProject compliance issues and pushed a commit to this Pull Request.

@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot check project-compliance

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 12, 2022

@FraserGreenroyd to confirm, the following checks are now queued:

  • project-compliance

There are 2 requests in the queue ahead of you.

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 12, 2022

@FraserGreenroyd just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 12, 2022

@FraserGreenroyd just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoMAnalytics_Toolkit

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 12, 2022

@FraserGreenroyd just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

adecler
adecler previously approved these changes Jan 13, 2022
Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a minor correction on a duplicate using but otherwise looks good.
The BHoM_UI is heavily using reflection (e.g. for the attribute methods) so not critical to trim the using references to the reflection engine.

@adecler
Copy link
Member

adecler commented Jan 13, 2022

As per comment in the Excel_Toolkit PR, I fixed the broken SetProperty component.

Copy link
Member

@adecler adecler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now all seems to be good

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 13, 2022

@FraserGreenroyd just to let you know, I have provided a check-versioning result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 13, 2022

@FraserGreenroyd just to let you know, I have provided a check-installer result to this Pull Request as it was detected to be linked to other Pull Requests in a series. The comment which triggered this check came from @FraserGreenroyd on BHoM_Engine

@FraserGreenroyd FraserGreenroyd marked this pull request as ready for review January 13, 2022 11:30
@FraserGreenroyd
Copy link
Contributor Author

@BHoMBot this is a DevOps instruction. I am requesting neutral checks on: core, code-compliance, copyright-compliance, dataset-compliance, documentation-compliance, null-handling, project-compliance, ready-to-merge, serialisation

@bhombot-ci
Copy link

bhombot-ci bot commented Jan 13, 2022

@FraserGreenroyd I have provided neutral checks to the checks requested. These checks will need to be run properly to obtain full results.

@FraserGreenroyd FraserGreenroyd merged commit 787fa9c into main Jan 13, 2022
@FraserGreenroyd FraserGreenroyd deleted the Reflection_oM-#1338-MigrateObjects branch January 13, 2022 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:compliance Non-conforming to code guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants