Migrate ISettings to the oM.Base namespace #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BHoMBot check required |
|
@adecler to confirm, the following checks are now queued:
|
FraserGreenroyd
approved these changes
Jun 1, 2021
|
@BHoMBot check copyright-compliance |
|
@FraserGreenroyd to confirm, the following checks are now queued:
There are 11 requests in the queue ahead of you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on
BHoM/BHoM#1249
Issues addressed by this PR
Closes #393
To add a bit of context: Adapters like the BuildingPerformance adapter will need to depend on ISettings to store the link to the database. So it is important that we don't add dependencies between adapter toolklits and the BHoM_UI repo (even if
ISettingsis inoM.UI, this is still a repo-level dependency we would like to avoid)Test files
Just make sure everything still compiles and that an installer can be created.